Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(minor): add a filter to avoid send work anniversary reminders for zero year #28092

Merged
merged 2 commits into from
Oct 27, 2021
Merged

fix(minor): add a filter to avoid send work anniversary reminders for zero year #28092

merged 2 commits into from
Oct 27, 2021

Conversation

gsi-maruiz
Copy link
Contributor

Please provide enough information so that others can review your pull request:
issue:#28091
In this PR. I add a filter by Year to avoid send reminders for zero year

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

@gsi-maruiz gsi-maruiz changed the title Work Anniversary Reminder is execute for zero years fix(minor): add a filter to avoid send work anniversary reminders for zero year Oct 26, 2021
@ruchamahabal ruchamahabal merged commit 8cad23b into frappe:version-13-hotfix Oct 27, 2021
@ruchamahabal
Copy link
Member

@Mergifyio backport develop

mergify bot pushed a commit that referenced this pull request Oct 27, 2021
@gsi-maruiz
fix: add filter to query to avoid send reminder for zero years (#28092)
5d52899 
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit 8cad23b)
@mergify mergify bot mentioned this pull request Oct 27, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

backport develop

✅ Backports have been created

ruchamahabal pushed a commit that referenced this pull request Oct 27, 2021
@mergify @gsi-maruiz
fix: add filter to query to avoid send reminder for zero years (#28092)…
25d1c1c 
… (#28096)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit 8cad23b)

Co-authored-by: gsi-maruiz <62341390+gsi-maruiz@users.noreply.github.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@gsi-maruiz @ruchamahabal
fix: add filter to query to avoid send reminder for zero years (frapp…
b22ef63 
…e#28092)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal approved these changes

@pateljannat pateljannat Awaiting requested review from pateljannat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsi-maruiz @ruchamahabal