Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): misleading label for image fields #28107

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 27, 2021

BOM doctype has two image fields with the same label "Image". This is confusing in some context.

Screenshot 2021-10-27 at 2 55 16 PM

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #28107 (be45e5b) into develop (9c17052) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28107      +/-   ##
===========================================
+ Coverage    55.19%   55.23%   +0.04%     
===========================================
  Files         1255     1255              
  Lines        67877    67929      +52     
===========================================
+ Hits         37465    37523      +58     
+ Misses       30412    30406       -6     
Impacted Files Coverage Δ
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 74.90% <100.00%> (ø)
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
erpnext/controllers/status_updater.py 85.71% <0.00%> (-1.86%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 45.11% <0.00%> (-1.51%) ⬇️
erpnext/stock/reorder_item.py 76.27% <0.00%> (-0.85%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.55% <0.00%> (-0.69%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.86% <0.00%> (-0.24%) ⬇️
...cturing/doctype/production_plan/production_plan.py 69.56% <0.00%> (-0.22%) ⬇️
erpnext/stock/get_item_details.py 79.51% <0.00%> (-0.03%) ⬇️
... and 19 more

@ankush ankush merged commit e0cf45e into frappe:develop Oct 27, 2021
@ankush ankush deleted the bom_img_field branch October 27, 2021 09:57
mergify bot pushed a commit that referenced this pull request Oct 27, 2021
ankush added a commit that referenced this pull request Oct 27, 2021
(cherry picked from commit e0cf45e)

Co-authored-by: Ankush Menat <ankush@frappe.io>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
(cherry picked from commit e0cf45e)

Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant