Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update_invoice_status with query builder #28160

Merged
merged 6 commits into from
Jan 3, 2022

Conversation

pruthvi145
Copy link
Contributor

@pruthvi145 pruthvi145 commented Oct 30, 2021

Continuation of #28019

converted raw SQL Query to Query Builder for update_invoice_status

@pruthvi145 pruthvi145 force-pushed the fix-invoice-statuses branch 3 times, most recently from 3008f6d to 210dc3e Compare October 30, 2021 10:30
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #28160 (fc0dd3f) into develop (56b9ad8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28160      +/-   ##
===========================================
+ Coverage    55.68%   55.72%   +0.03%     
===========================================
  Files         1129     1129              
  Lines        67471    67483      +12     
===========================================
+ Hits         37574    37603      +29     
+ Misses       29897    29880      -17     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 84.32% <100.00%> (+0.39%) ⬆️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
...vs_serial_no_count/stock_qty_vs_serial_no_count.py 92.85% <0.00%> (-3.58%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.93% <0.00%> (-2.74%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
erpnext/support/doctype/issue/issue.py 64.03% <0.00%> (-0.99%) ⬇️
erpnext/stock/stock_ledger.py 85.02% <0.00%> (-0.56%) ⬇️
erpnext/stock/get_item_details.py 79.29% <0.00%> (-0.16%) ⬇️
erpnext/stock/reorder_item.py 76.92% <0.00%> (ø)
... and 13 more

@pruthvi145 pruthvi145 marked this pull request as ready for review October 30, 2021 11:14
@sagarvora sagarvora changed the title refactor: update_invoice_status with query builder refactor: update_invoice_status with query builder Oct 30, 2021
@deepeshgarg007
Copy link
Member

@pruthvi145, since you are at it, can also take into account the status of the invoice which are discounted. Invoice discounting is completely ignored while updating the status

@pruthvi145
Copy link
Contributor Author

@pruthvi145, since you are at it, can also take into account the status of the invoice which are discounted. Invoice discounting is completely ignored while updating the status

Fixed

@stale
Copy link

stale bot commented Nov 30, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 30, 2021
@stale stale bot closed this Dec 3, 2021
@ankush ankush reopened this Dec 3, 2021
@stale stale bot removed the inactive label Dec 3, 2021
@nextchamp-saqib nextchamp-saqib added the needs-tests This PR needs automated unit-tests. label Dec 15, 2021
@nextchamp-saqib
Copy link
Member

@pruthvi145 Hey, can you add a basic test for checking if the Unpaid invoice goes to Overdue state once the due date has passed?

@nextchamp-saqib nextchamp-saqib self-assigned this Dec 15, 2021
@pruthvi145
Copy link
Contributor Author

@nextchamp-saqib added test cases.

@nextchamp-saqib nextchamp-saqib removed the needs-tests This PR needs automated unit-tests. label Jan 3, 2022
@nextchamp-saqib nextchamp-saqib merged commit 7e77735 into frappe:develop Jan 3, 2022
@nextchamp-saqib
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2022

backport version-13-hotfix

✅ Backports have been created

nextchamp-saqib added a commit that referenced this pull request Jan 3, 2022
…-28160

refactor: `update_invoice_status` with query builder (backport #28160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants