fix: incorrect status being set in Invoices #28019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarvora
force-pushed
the
fix-invoice-statuses
branch
from
4de53cf
to
eae39a2
Compare
This was referenced Oct 20, 2021
pruthvi145
force-pushed
the
fix-invoice-statuses
branch
3 times, most recently
from
f88c1d1
to
785244a
Compare
sagarvora
requested review from
deepeshgarg007,
marination and
rohitwaghchaure
as code owners
pruthvi145
force-pushed
the
fix-invoice-statuses
branch
from
785244a
to
2e50c66
Compare
Codecov Report
@@ Coverage Diff @@
## develop #28019 +/- ##
===========================================
+ Coverage 54.26% 54.34% +0.07%
===========================================
Files 1255 1255
Lines 67831 67851 +20
===========================================
+ Hits 36810 36874 +64
+ Misses 31021 30977 -44
|
pruthvi145
force-pushed
the
fix-invoice-statuses
branch
from
b5d7063
to
634c091
Compare
pruthvi145
force-pushed
the
fix-invoice-statuses
branch
from
634c091
to
2ef4844
Compare
nextchamp-saqib
approved these changes
Oct 20, 2021
|
@Mergifyio backport version-13-hotfix |
|
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions
|
🟠 Waiting for conditions
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2021
Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com> (cherry picked from commit 8d9d098) # Conflicts: # erpnext/patches.txt
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2021
Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com> (cherry picked from commit 8d9d098) # Conflicts: # erpnext/patches.txt
✅ Backports have been created
|
sagarvora
added a commit
that referenced
this pull request
Oct 20, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…rappe#28031) * fix: incorrect status being set in Invoices (frappe#28019) Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com> (cherry picked from commit 8d9d098) # Conflicts: # erpnext/patches.txt * fix: merge conflict Co-authored-by: Sagar Vora <sagar@resilient.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues described in #27921, #27992, #28023
Failing test due to newly introduced QB check. Focus currently is on getting this fix out, so skipping QB for now.