feat: provision to have limited parameters for in-process quality inspection #28219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeMysterio
requested review from
ankush,
marination and
rohitwaghchaure
as code owners
DeeMysterio
force-pushed
the
in-process-qi
branch
from
5f02ab3
to
5da83d2
Compare
DeeMysterio
force-pushed
the
in-process-qi
branch
from
5da83d2
to
6c45f8b
Compare
| for d in parameters: | ||
| if reading.specification == d.specification: | ||
| reading.update(d) | ||
| reading.status = "Accepted" |
There was a problem hiding this comment.
Why status as "Accepted", it's depending on the condition
| @@ -292,6 +293,10 @@ def update_sub_operation_status(self): | |||
| row.completed_time = 0.0 | |||
| row.completed_qty = 0.0 | |||
|
|
|||
| def set_quality_inspection_template(self): | |||
| qi_template = frappe.db.get_value('Operation', self.operation, 'quality_inspection_template') | |||
| self.quality_inspection_template = qi_template | |||
There was a problem hiding this comment.
Use fetch from property in the doctype
|
@Mergifyio backport version-13-pre-release |
✅ Backports have been created
|
rohitwaghchaure
added a commit
that referenced
this pull request
Nov 9, 2021
…se/pr-28219 feat: provision to have limited parameters for in-process quality inspection (backport #28219)
|
@Mergifyio backport develop |
✅ Backports have been created
|
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…-release/pr-28219 feat: provision to have limited parameters for in-process quality inspection (backport frappe#28219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
Screenshots/Gifs:
Documentation:
https://docs.erpnext.com/docs/v13/user/manual/en/manufacturing/operation