Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provision to have limited parameters for in-process quality ins… #28549

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

DeeMysterio
Copy link
Contributor

@DeeMysterio DeeMysterio commented Nov 24, 2021

front port of: #28219
Additions:

  • fetch a custom QI template of job card while creating a Quality Inspection from a Job card
  • fetch min max numeric values or formula for its readings table from the QI template set on item of that Job Card on saving of the Quality Inspection

Screenshots/Gifs:
in-process-qii

Documentation:
https://docs.erpnext.com/docs/v13/user/manual/en/manufacturing/operation

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #28549 (6b855dc) into develop (228e011) will decrease coverage by 0.23%.
The diff coverage is 12.50%.

❗ Current head 6b855dc differs from pull request most recent head 6abcfda. Consider uploading reports for the commit 6abcfda to get more accurate results

@@             Coverage Diff             @@
##           develop   #28549      +/-   ##
===========================================
- Coverage    55.54%   55.30%   -0.24%     
===========================================
  Files         1126     1119       -7     
  Lines        67191    66644     -547     
===========================================
- Hits         37318    36858     -460     
+ Misses       29873    29786      -87     
Impacted Files Coverage Δ
...k/doctype/quality_inspection/quality_inspection.py 62.04% <12.50%> (-3.08%) ⬇️
...d_supplies/hsn_wise_summary_of_outward_supplies.py 0.00% <0.00%> (-72.39%) ⬇️
...ext/stock/doctype/stock_entry/stock_entry_utils.py 85.29% <0.00%> (-8.83%) ⬇️
erpnext/stock/doctype/packed_item/packed_item.py 75.67% <0.00%> (-8.54%) ⬇️
erpnext/regional/report/gstr_1/gstr_1.py 0.00% <0.00%> (-8.36%) ⬇️
...poor_quality_report/cost_of_poor_quality_report.py 48.57% <0.00%> (-4.77%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
erpnext/support/doctype/issue/issue.py 63.41% <0.00%> (-1.61%) ⬇️
... and 88 more

@stale
Copy link

stale bot commented Dec 9, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Dec 9, 2021
@stale stale bot closed this Dec 12, 2021
@ankush ankush reopened this Dec 14, 2021
@stale stale bot removed the inactive label Dec 14, 2021
@ankush ankush merged commit 2be62c2 into frappe:develop Dec 15, 2021
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
frappe#28549)

* feat: provision to have limited parameters for in-process quality inspection

* chore: formatting
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
frappe#28549)

* feat: provision to have limited parameters for in-process quality inspection

* chore: formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants