fix: filter only submitted fees in student fee collection report #28280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: filter and show only submitted fees documents
Codecov Report
@@ Coverage Diff @@
## develop #28280 +/- ##
===========================================
+ Coverage 55.23% 55.25% +0.01%
===========================================
Files 1117 1117
Lines 66494 66494
===========================================
+ Hits 36729 36738 +9
+ Misses 29765 29756 -9
|
ruchamahabal
approved these changes
Nov 9, 2021
|
@Mergifyio backport version-13-hotfix |
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2021
) * Update student_fee_collection.json Fix: filter and show only submitted fees documents * fix: add total row for the student fee collection (cherry picked from commit 0e8e7e2)
✅ Backports have been created
|
ruchamahabal
added a commit
that referenced
this pull request
Nov 9, 2021
) (#28282) * Update student_fee_collection.json Fix: filter and show only submitted fees documents * fix: add total row for the student fee collection (cherry picked from commit 0e8e7e2) Co-authored-by: Bibin <17405044+bibinqcs@users.noreply.github.com> Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
…ppe#28280) * Update student_fee_collection.json Fix: filter and show only submitted fees documents * fix: add total row for the student fee collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am suggesting this fix to solve an issue with cancelled Fees documents reflecting in the paid column of the Student Fee Collection report, I noticed this while making test entries in V13 i.e ERPNext: v13.13.0 (version-13), Adding the total row was useful to see the total amount of all the fees documents
Made changes to the student_fee_collection.json
To filter out and show only submitted documents added in "query" WHERE docstatus=1
To Show the Total Row added "add_total_row": 1,
Before Fix
After Fix