Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: specify fields to be set in Lead #28288

Merged
merged 1 commit into from
Nov 9, 2021
Merged

fix: specify fields to be set in Lead #28288

merged 1 commit into from
Nov 9, 2021

Conversation

sagarvora
Copy link
Collaborator

Restricts fields that can be set to the fields being displayed in the dialog box here.

@sagarvora
Copy link
Collaborator Author

v13 backport will be done manually. The function has been moved with the e-commerce refactor.

@sagarvora
Copy link
Collaborator Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

backport version-12-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@sagarvora sagarvora mentioned this pull request Nov 9, 2021
Merged
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #28288 (63f0d80) into develop (4a3cef6) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #28288      +/-   ##
===========================================
+ Coverage    55.22%   55.26%   +0.03%     
===========================================
  Files         1117     1117              
  Lines        66496    66497       +1     
===========================================
+ Hits         36725    36750      +25     
+ Misses       29771    29747      -24
Impacted Files Coverage Δ
erpnext/shopping_cart/cart.py 50.57% <0.00%> (-0.15%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (-1.32%) ⬇️
erpnext/stock/reorder_item.py 76.92% <0.00%> (-0.86%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.13% <0.00%> (-0.70%) ⬇️
erpnext/hr/utils.py 74.29% <0.00%> (-0.41%) ⬇️
erpnext/stock/stock_ledger.py 86.36% <0.00%> (-0.37%) ⬇️
erpnext/projects/doctype/project/project.py 53.73% <0.00%> (-0.36%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.79% <0.00%> (-0.24%) ⬇️
erpnext/stock/get_item_details.py 79.44% <0.00%> (-0.16%) ⬇️
... and 12 more

@sagarvora sagarvora merged commit da22744 into frappe:develop Nov 9, 2021
mergify bot pushed a commit that referenced this pull request Nov 9, 2021
@sagarvora
fix: specify fields to be set in Lead (#28288)
22a4f35 
(cherry picked from commit da22744)

# Conflicts:
#	erpnext/shopping_cart/cart.py
@mergify mergify bot mentioned this pull request Nov 9, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

backport version-12-hotfix

✅ Backports have been created

sagarvora added a commit that referenced this pull request Nov 9, 2021
@mergify @sagarvora
fix: specify fields to be set in Lead (backport #28288)
80ba0cf 
* fix: specify fields to be set in Lead (#28288)

(cherry picked from commit da22744)

# Conflicts:
#	erpnext/shopping_cart/cart.py

* fix: merge conflict

Co-authored-by: Sagar Vora <sagar@resilient.tech>
@commit-lint commit-lint bot mentioned this pull request Dec 3, 2021
Merged
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@sagarvora
fix: specify fields to be set in Lead (frappe#28288)
e3798ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavindsouza gavindsouza gavindsouza approved these changes

@marination marination Awaiting requested review from marination

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sagarvora @gavindsouza