Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(M-Pesa): validate type before executing get_doc #28369

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

sagarvora
Copy link
Collaborator

Type validation must be done before getting the Integration Request.

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #28369 (30cc7a1) into develop (fdb8e18) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #28369      +/-   ##
===========================================
- Coverage    55.25%   55.16%   -0.10%     
===========================================
  Files         1119     1119              
  Lines        66538    66553      +15     
===========================================
- Hits         36765    36712      -53     
- Misses       29773    29841      +68     
Impacted Files Coverage Δ
...egrations/doctype/mpesa_settings/mpesa_settings.py 74.05% <50.00%> (-0.63%) ⬇️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.06% <0.00%> (-1.57%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.05% <0.00%> (-1.50%) ⬇️
... and 18 more

@ankush ankush merged commit 6d3e9bc into frappe:develop Nov 12, 2021
mergify bot pushed a commit that referenced this pull request Nov 12, 2021
sagarvora added a commit that referenced this pull request Nov 12, 2021
(cherry picked from commit 6d3e9bc)

Co-authored-by: Sagar Vora <sagar@resilient.tech>
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants