Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added required_date field to set date in child table #28432

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

noahjacob
Copy link
Contributor

@noahjacob noahjacob commented Nov 17, 2021

Feature

  • Added a "Required Date" field that sets all the dates in the child table when set.

required_date

no_docs

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #28432 (c5bba43) into develop (4984513) will increase coverage by 7.40%.
The diff coverage is n/a.

❗ Current head c5bba43 differs from pull request most recent head 35dc35e. Consider uploading reports for the commit 35dc35e to get more accurate results

@@             Coverage Diff             @@
##           develop   #28432      +/-   ##
===========================================
+ Coverage    47.86%   55.26%   +7.40%     
===========================================
  Files         1125     1119       -6     
  Lines        66983    66636     -347     
===========================================
+ Hits         32059    36829    +4770     
+ Misses       34924    29807    -5117     
Impacted Files Coverage Δ
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...ext/stock/doctype/stock_entry/stock_entry_utils.py 85.29% <0.00%> (-8.83%) ⬇️
erpnext/stock/doctype/packed_item/packed_item.py 75.67% <0.00%> (-8.54%) ⬇️
...poor_quality_report/cost_of_poor_quality_report.py 48.57% <0.00%> (-4.77%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.06% <0.00%> (-1.57%) ⬇️
...e/employee_benefit_claim/employee_benefit_claim.py 88.28% <0.00%> (-1.57%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
... and 209 more

@stale
Copy link

stale bot commented Dec 10, 2021

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Dec 10, 2021
@noahjacob noahjacob added this to the v13.17 milestone Dec 13, 2021
@ankush ankush merged commit db46257 into frappe:develop Dec 14, 2021
mergify bot pushed a commit that referenced this pull request Dec 15, 2021
* feat: added required_date field to set date in child table

* fix: dont refresh full table

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit db46257)
mergify bot pushed a commit that referenced this pull request Dec 15, 2021
* feat: added required_date field to set date in child table

* fix: dont refresh full table

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit db46257)
ankush pushed a commit that referenced this pull request Dec 15, 2021
…28432)

feat: added required_date field to set date in child table (backport #28432)
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
)

* feat: added required_date field to set date in child table

* fix: dont refresh full table

Co-authored-by: Ankush Menat <ankush@frappe.io>
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
)

* feat: added required_date field to set date in child table

* fix: dont refresh full table

Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants