Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unchecking the "With Operations" in BOM clears operations table #28446

Merged
merged 1 commit into from
Nov 18, 2021
Merged

fix: unchecking the "With Operations" in BOM clears operations table #28446

merged 1 commit into from
Nov 18, 2021

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Nov 18, 2021 •
edited

Source/Reference: FR-ISS-322190

Before:

Screen.Recording.2021-11-18.at.1.47.28.PM.mov

After:

Screen.Recording.2021-11-18.at.1.12.18.PM.mov

Changes:

  1. Set "depends_on" property for "operations_section".
  2. Remove the JS function which was removing "Operations" while un-checking the "With Operations" checkbox in BOM.

@ankush ankush added backport version-13-hotfix Skip Manual Testing The changes in this PR does not require manual testing labels Nov 18, 2021
@ankush ankush changed the title fix: Remove all rows from operations while unchecking the "With Operations" in BOM fix: unchecking the "With Operations" in BOM clears operations table Nov 18, 2021
@ankush ankush merged commit 488d34a into frappe:develop Nov 18, 2021
mergify bot pushed a commit that referenced this pull request Nov 18, 2021
@s-aga-r
fix: unchecking the "With Operations" in BOM clears operations table #…
705602d 
…28446

(cherry picked from commit 488d34a)

# Conflicts:
#	erpnext/manufacturing/doctype/bom/bom.js
@mergify mergify bot mentioned this pull request Nov 18, 2021
Merged
ankush added a commit that referenced this pull request Nov 18, 2021
@mergify @s-aga-r @ankush
fix: unchecking the "With Operations" in BOM clears operations table …
a60c648 
…(backport #28446) (#28447)

* fix: unchecking the "With Operations" in BOM clears operations table #28446

(cherry picked from commit 488d34a)

# Conflicts:
#	erpnext/manufacturing/doctype/bom/bom.js

* fix: resolve conflict

Co-authored-by: Sagar Sharma <63660334+s-aga-r@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
@s-aga-r s-aga-r deleted the BOM-checkbox branch November 18, 2021 15:32
@sharmanakul sharmanakul mentioned this pull request Nov 25, 2021
Closed
@commit-lint commit-lint bot mentioned this pull request Dec 6, 2021
Merged
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@s-aga-r
fix: unchecking the "With Operations" in BOM clears operations table f…
015a94c 
…rappe#28446
@s-aga-r s-aga-r added bug and removed Skip Manual Testing The changes in this PR does not require manual testing backport version-13-hotfix labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-aga-r @ankush