-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Closed status error in Work Order Summary #28460
fix: Closed status error in Work Order Summary #28460
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28460 +/- ##
===========================================
+ Coverage 55.26% 55.32% +0.06%
===========================================
Files 1119 1119
Lines 66598 66603 +5
===========================================
+ Hits 36805 36849 +44
+ Misses 29793 29754 -39
|
Add minimal steps to reproduce in description so in future if someone wants to validate the fix they will get the context. E.g. in this case it would be to create a work order, close it and then open this report. |
erpnext/manufacturing/report/work_order_summary/work_order_summary.py
Outdated
Show resolved
Hide resolved
d32d0bc
to
466e1c3
Compare
* fix: Closed status error in Work Order Summary * chore: use get_meta to get status options * refactor: simplify code Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit aa68987) # Conflicts: # erpnext/manufacturing/report/work_order_summary/work_order_summary.py
* fix: Closed status error in Work Order Summary * chore: use get_meta to get status options * refactor: simplify code Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit aa68987) # Conflicts: # erpnext/manufacturing/report/work_order_summary/work_order_summary.py
* fix: Closed status error in Work Order Summary (#28460) * fix: Closed status error in Work Order Summary * chore: use get_meta to get status options * refactor: simplify code Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit aa68987) # Conflicts: # erpnext/manufacturing/report/work_order_summary/work_order_summary.py * fix: resolve conflict Co-authored-by: Sagar Sharma <63660334+s-aga-r@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@frappe.io>
* fix: Closed status error in Work Order Summary (#28460) * fix: Closed status error in Work Order Summary * chore: use get_meta to get status options * refactor: simplify code Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit aa68987) # Conflicts: # erpnext/manufacturing/report/work_order_summary/work_order_summary.py * fix: resolve conflict Co-authored-by: Sagar Sharma <63660334+s-aga-r@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@frappe.io>
* fix: Closed status error in Work Order Summary * chore: use get_meta to get status options * refactor: simplify code Co-authored-by: Ankush Menat <ankush@frappe.io>
* fix: Closed status error in Work Order Summary * chore: use get_meta to get status options * refactor: simplify code Co-authored-by: Ankush Menat <ankush@frappe.io>
Source/Reference: ISS-21-22-08765
Introduced by #28150
Before:
After:
Steps to Validate:
Changes: Add "Closed" status while getting and displaying the data.