Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Closed status error in Work Order Summary #28460

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Nov 19, 2021

Source/Reference: ISS-21-22-08765

Introduced by #28150

Before:
ezgif com-gif-maker

After:
ezgif com-gif-maker

Steps to Validate:
Screen Recording 2021-11-19 at 4 58 27 PM

Changes: Add "Closed" status while getting and displaying the data.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #28460 (2286305) into develop (488d34a) will increase coverage by 0.06%.
The diff coverage is 83.33%.

❗ Current head 2286305 differs from pull request most recent head 2784d4e. Consider uploading reports for the commit 2784d4e to get more accurate results

@@             Coverage Diff             @@
##           develop   #28460      +/-   ##
===========================================
+ Coverage    55.26%   55.32%   +0.06%     
===========================================
  Files         1119     1119              
  Lines        66598    66603       +5     
===========================================
+ Hits         36805    36849      +44     
+ Misses       29793    29754      -39     
Impacted Files Coverage Δ
...ng/report/work_order_summary/work_order_summary.py 74.22% <0.00%> (ø)
erpnext/controllers/taxes_and_totals.py 97.65% <100.00%> (+0.02%) ⬆️
...e/asset_value_adjustment/asset_value_adjustment.py 87.65% <0.00%> (-3.71%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 90.51% <0.00%> (-2.92%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 91.37% <0.00%> (-1.73%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.60% <0.00%> (-1.63%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.83% <0.00%> (-0.44%) ⬇️
erpnext/hr/utils.py 74.29% <0.00%> (-0.41%) ⬇️
... and 12 more

@ankush
Copy link
Member

ankush commented Nov 19, 2021

Add minimal steps to reproduce in description so in future if someone wants to validate the fix they will get the context.

E.g. in this case it would be to create a work order, close it and then open this report.

@s-aga-r s-aga-r force-pushed the work-order-summary-closed-status branch from d32d0bc to 466e1c3 Compare November 22, 2021 07:18
@ankush ankush merged commit aa68987 into frappe:develop Nov 22, 2021
mergify bot pushed a commit that referenced this pull request Nov 22, 2021
* fix: Closed status error in Work Order Summary

* chore: use get_meta to get status options

* refactor: simplify code

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit aa68987)

# Conflicts:
#	erpnext/manufacturing/report/work_order_summary/work_order_summary.py
mergify bot pushed a commit that referenced this pull request Nov 22, 2021
* fix: Closed status error in Work Order Summary

* chore: use get_meta to get status options

* refactor: simplify code

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit aa68987)

# Conflicts:
#	erpnext/manufacturing/report/work_order_summary/work_order_summary.py
ankush added a commit that referenced this pull request Nov 22, 2021
* fix: Closed status error in Work Order Summary (#28460)

* fix: Closed status error in Work Order Summary

* chore: use get_meta to get status options

* refactor: simplify code

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit aa68987)

# Conflicts:
#	erpnext/manufacturing/report/work_order_summary/work_order_summary.py

* fix: resolve conflict

Co-authored-by: Sagar Sharma <63660334+s-aga-r@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request Nov 22, 2021
* fix: Closed status error in Work Order Summary (#28460)

* fix: Closed status error in Work Order Summary

* chore: use get_meta to get status options

* refactor: simplify code

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit aa68987)

# Conflicts:
#	erpnext/manufacturing/report/work_order_summary/work_order_summary.py

* fix: resolve conflict

Co-authored-by: Sagar Sharma <63660334+s-aga-r@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
@ankush ankush added this to the v13.15 milestone Nov 22, 2021
@s-aga-r s-aga-r deleted the work-order-summary-closed-status branch November 22, 2021 11:03
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
* fix: Closed status error in Work Order Summary

* chore: use get_meta to get status options

* refactor: simplify code

Co-authored-by: Ankush Menat <ankush@frappe.io>
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
* fix: Closed status error in Work Order Summary

* chore: use get_meta to get status options

* refactor: simplify code

Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants