fix: Use get_all instead of get_list for child doctype
#28538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not fixing sider issues for query builder. Not useful. |
Codecov Report
@@ Coverage Diff @@
## develop #28538 +/- ##
===========================================
- Coverage 55.26% 55.23% -0.04%
===========================================
Files 1119 1119
Lines 66672 66673 +1
===========================================
- Hits 36847 36827 -20
- Misses 29825 29846 +21
|
|
No other instances found in:
|
ruchamahabal
changed the title
get_all instead of get_list for child doctypeget_all instead of get_list for child doctype
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2021
* fix(Student Attendance Tool): Use `get_all` instead of `get_list` for child doctype * fix(Course Schedule): incorrect fetch from value * fix: sider * fix(Gratuity): Use `get_all` instead of `get_list` for child doctype (cherry picked from commit ca8dec0)
ruchamahabal
added a commit
that referenced
this pull request
Nov 26, 2021
…28577) * fix(Student Attendance Tool): Use `get_all` instead of `get_list` for child doctype * fix(Course Schedule): incorrect fetch from value * fix: sider * fix(Gratuity): Use `get_all` instead of `get_list` for child doctype (cherry picked from commit ca8dec0) Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Student Attendance marking from the tool not working:
Use
get_allinstead ofget_listfor child doctype queries. This change is required to avoid the permission error due to the change made in frappe/frappe#14526Also fixed incorrect "fetch from" value in Course Schedule doctype for Instructor Name