Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): remove attachment limit from item doctype #28632

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Nov 30, 2021

limit of 1 is way too low for Item, users would typically want to store item images, cataglog/spec etc on same document.

Also removed limit from:

  • quotation
  • stock reconciliation

AFAIK We have no reason to restrict how many attachments should be added to these doctypes.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #28632 (72895fe) into develop (69a17b9) will increase coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28632      +/-   ##
===========================================
+ Coverage    55.18%   55.30%   +0.12%     
===========================================
  Files         1120     1121       +1     
  Lines        66673    66746      +73     
===========================================
+ Hits         36791    36913     +122     
+ Misses       29882    29833      -49     
Impacted Files Coverage Δ
erpnext/regional/saudi_arabia/utils.py 24.05% <0.00%> (-11.51%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.24% <0.00%> (-1.46%) ⬇️
erpnext/assets/doctype/asset/asset.py 74.23% <0.00%> (-1.02%) ⬇️
erpnext/accounts/deferred_revenue.py 75.11% <0.00%> (-0.89%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-0.86%) ⬇️
.../support/report/issue_analytics/issue_analytics.py 88.98% <0.00%> (-0.85%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.29% <0.00%> (-0.27%) ⬇️
erpnext/accounts/utils.py 59.04% <0.00%> (-0.19%) ⬇️
erpnext/hooks.py 0.00% <0.00%> (ø)
erpnext/hr/utils.py 74.29% <0.00%> (ø)
... and 25 more

@ankush ankush merged commit aeb62af into frappe:develop Nov 30, 2021
@ankush ankush deleted the remove_attachment_limit_item branch November 30, 2021 07:17
ankush pushed a commit that referenced this pull request Nov 30, 2021
fix(ux): remove attachment limit from item doctype (backport #28632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant