test: dynamic Fiscal Year creation in tests #28667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
|
Update |
update what exactly? 馃 馃槙 |
|
Oops. My bad |
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2021
(cherry picked from commit fdffa03)
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2021
(cherry picked from commit fdffa03)
ankush
added a commit
that referenced
this pull request
Dec 1, 2021
ankush
added a commit
that referenced
this pull request
Dec 1, 2021
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2021
(cherry picked from commit fdffa03) # Conflicts: # erpnext/accounts/doctype/fiscal_year/test_fiscal_year.py # erpnext/accounts/doctype/fiscal_year/test_records.json
ankush
added a commit
that referenced
this pull request
Dec 14, 2021
(cherry picked from commit fdffa03) fix: resolve conflict fix
ankush
added a commit
that referenced
this pull request
Dec 14, 2021
(cherry picked from commit fdffa03) fix: resolve conflict fix
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few tests are failing because FY 2021-2022 doesn't exist and reports are trying to fetch FY of 1 month from today.
Root cause: FY up to 2021 were hardcoded in test records 馃ゲ so they were scheduled to fail today.
Fix: Dynamic FY for test records, from 2011 to (today + 4 years)