Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Non Profit): fetch memberships for 80G certificate by from date only #28700

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

ruchamahabal
Copy link
Member

It's possible for a membership to start in the last month of this fiscal year and end in the first month of the next fiscal year. In such a case, this membership will never be fetched in any 80G certificate because it checks for both Start and End dates for memberships.

Ideally, only the From Date should be checked since 80G is handed out for payments done and payments are done at the start of the membership period so To Date should not come into the picture while fetching memberships.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #28700 (be655b9) into develop (a37c99a) will increase coverage by 8.80%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop   #28700      +/-   ##
===========================================
+ Coverage    46.44%   55.25%   +8.80%     
===========================================
  Files         1121     1121              
  Lines        66770    66781      +11     
===========================================
+ Hits         31012    36899    +5887     
+ Misses       35758    29882    -5876     
Impacted Files Coverage Δ
...n_80g_certificate/tax_exemption_80g_certificate.py 91.66% <ø> (+91.66%) ⬆️
.../report/accounts_receivable/accounts_receivable.py 68.37% <91.66%> (+68.37%) ⬆️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...t/payroll/doctype/payroll_period/payroll_period.py 64.81% <0.00%> (-5.56%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.78% <0.00%> (-2.92%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.60% <0.00%> (-2.44%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-1.99%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.24% <0.00%> (-0.69%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 78.57% <0.00%> (-0.60%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.74% <0.00%> (-0.57%) ⬇️
... and 223 more

@ruchamahabal ruchamahabal merged commit 0b1808e into frappe:develop Dec 3, 2021
@ruchamahabal
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2021

backport version-13-hotfix

✅ Backports have been created

ruchamahabal added a commit that referenced this pull request Dec 3, 2021
…nly (#28700) (#28704)

(cherry picked from commit 0b1808e)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant