Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: dont allow renaming warehouse primary key #28712

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Dec 3, 2021

If a mistake is made while naming the warehouse it should be corrected using stock transfer + disabling the original warehouse.

The display name can still be changed; only name can't be changed.

We are working on a better tool for handling things like items, warehouse renames; until then this has to go because it has the potential to cause inconsistent data.

Other change:

  • remove autocommit from item rename

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #28712 (fb9c0ca) into develop (0b1808e) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28712      +/-   ##
===========================================
+ Coverage    55.21%   55.27%   +0.06%     
===========================================
  Files         1121     1121              
  Lines        66785    66750      -35     
===========================================
+ Hits         36872    36895      +23     
+ Misses       29913    29855      -58     
Impacted Files Coverage Δ
erpnext/stock/doctype/item/item.py 66.75% <ø> (-0.09%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 43.22% <ø> (-11.09%) ⬇️
erpnext/stock/doctype/bin/bin.py 87.27% <0.00%> (-4.54%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
erpnext/stock/utils.py 65.27% <0.00%> (-2.10%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (-1.32%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 77.23% <0.00%> (-0.82%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.24% <0.00%> (-0.69%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.74% <0.00%> (-0.57%) ⬇️
... and 21 more

@ankush ankush merged commit 5caf411 into frappe:develop Dec 3, 2021
ankush added a commit that referenced this pull request Dec 14, 2021
* fix!: dont allow renaming warehouse primary key

(cherry picked from commit 72dbc3d)

* fix: remove autocommit from item rename

(cherry picked from commit 5caf411)

Co-authored-by: Ankush Menat <ankush@frappe.io>
@Ponyooooo
Copy link

is the renaming tool for the warehouse available already? why not remove the function on renaming the serial numbers and batch numbers also?

@s-aga-r s-aga-r mentioned this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants