Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UX): hide RM table(Job Card) if material transfer is against work order #28746

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix(UX): hide RM table(Job Card) if material transfer is against work order #28746

merged 1 commit into from
Dec 14, 2021

Conversation

noahjacob
Copy link
Contributor

Before

image

  • When "Transfer Material Against" is set to Work Order, the Raw Materials table was editable and visible in the Job Card.

hide_before

Changes

  • The Raw Material table in Job Card is now hidden if the Transfer Material Against is set to Work Order.

hide_after

@sharmanakul sharmanakul added this to In progress in ERPNext Roadmap via automation Dec 7, 2021
@sharmanakul sharmanakul added this to the v13.17 milestone Dec 7, 2021
@ankush ankush merged commit cc8c059 into frappe:develop Dec 14, 2021
ERPNext Roadmap automation moved this from In progress to Done Dec 14, 2021
mergify bot pushed a commit that referenced this pull request Dec 14, 2021
@noahjacob
fix(UX): hide RM table(Job Card) if material transfer is against work…
ff99698 
… order (#28746)

(cherry picked from commit cc8c059)

# Conflicts:
#	erpnext/manufacturing/doctype/job_card/job_card.js
@mergify mergify bot mentioned this pull request Dec 14, 2021
Merged
ankush added a commit that referenced this pull request Dec 14, 2021
@mergify @noahjacob @ankush
fix(UX): hide RM table(Job Card) if material transfer is against work…
1a986f0 
… order (backport #28746)

* fix(UX): hide RM table(Job Card) if material transfer is against work order (#28746)

(cherry picked from commit cc8c059)

# Conflicts:
#	erpnext/manufacturing/doctype/job_card/job_card.js

* chore: resolve conflicts

Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
@rohitwaghchaure rohitwaghchaure mentioned this pull request Jan 6, 2022
Merged
@commit-lint commit-lint bot mentioned this pull request Jan 7, 2022
Merged
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@noahjacob
fix(UX): hide RM table(Job Card) if material transfer is against work…
d5f0e3d 
… order (frappe#28746)
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@noahjacob
fix(UX): hide RM table(Job Card) if material transfer is against work…
931c8ca 
… order (frappe#28746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
No open projects
ERPNext Roadmap
Done
Milestone
v13.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noahjacob @ankush @sharmanakul