Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deduplicate after finishing the repost #28803

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix: deduplicate after finishing the repost #28803

merged 1 commit into from
Dec 9, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Dec 9, 2021

Not really a bug but avoids the potential of prematurely skipping something if a failure occurs and failure isn't resolved.

@ankush
fix: deduplicate after finishing the repost
1fdfc7c 
Not really a bug but avoids potential of prematurely skipping something
if failure occurs and failure isn't resolved.
@ankush ankush added Skip Manual Testing The changes in this PR does not require manual testing backport version-13-hotfix labels Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #28803 (1fdfc7c) into develop (96a019e) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #28803      +/-   ##
===========================================
+ Coverage    55.22%   55.25%   +0.03%     
===========================================
  Files         1122     1122              
  Lines        66782    66789       +7     
===========================================
+ Hits         36879    36907      +28     
+ Misses       29903    29882      -21
Impacted Files Coverage Δ
...ype/repost_item_valuation/repost_item_valuation.py 64.40% <0.00%> (ø)
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
erpnext/stock/reorder_item.py 75.21% <0.00%> (-0.86%) ⬇️
erpnext/projects/doctype/project/project.py 53.73% <0.00%> (-0.36%) ⬇️
erpnext/stock/stock_ledger.py 85.73% <0.00%> (-0.35%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.79% <0.00%> (-0.24%) ⬇️
erpnext/hooks.py 0.00% <0.00%> (ø)
erpnext/regional/saudi_arabia/setup.py 0.00% <0.00%> (ø)
...stock/doctype/purchase_receipt/purchase_receipt.py 90.29% <0.00%> (ø)
... and 14 more

@ankush ankush merged commit c64d502 into frappe:develop Dec 9, 2021
mergify bot pushed a commit that referenced this pull request Dec 9, 2021
@ankush
fix: deduplicate after finishing the repost (#28803)
616d748 
Not really a bug but avoids potential of prematurely skipping something
if failure occurs and failure isn't resolved.

(cherry picked from commit c64d502)
@mergify mergify bot mentioned this pull request Dec 9, 2021
Merged
ankush added a commit that referenced this pull request Dec 9, 2021
@mergify @ankush
fix: deduplicate after finishing the repost (#28803) (#28806)
4d0d39c 
Not really a bug but avoids potential of prematurely skipping something
if failure occurs and failure isn't resolved.

(cherry picked from commit c64d502)

Co-authored-by: Ankush Menat <ankush@frappe.io>
@ankush ankush deleted the dedup_post_finishing branch December 9, 2021 12:10
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@ankush
fix: deduplicate after finishing the repost (frappe#28803)
a4a35ac 
Not really a bug but avoids potential of prematurely skipping something
if failure occurs and failure isn't resolved.
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@ankush
fix: deduplicate after finishing the repost (frappe#28803)
dfef75c 
Not really a bug but avoids potential of prematurely skipping something
if failure occurs and failure isn't resolved.
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ankush