Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Currency fix for cost field in subscription plan #28821

Merged

Conversation

nemesis189
Copy link
Contributor

Issue:
The cost field of Subscription plan would always have the company currency

Before: Screenshot 2021-12-10 at 6 33 49 PM Screenshot 2021-12-10 at 6 34 06 PM
After: Screenshot 2021-12-10 at 6 39 26 PM Screenshot 2021-12-10 at 6 39 44 PM

Fix:
Picking up the currency from the currency link field in the form

steps:

  1. create a new Subscription Plan with currency different than the company currency
  2. Save and check in the list view if correct one is displayed

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #28821 (438e6a3) into develop (9a644f6) will increase coverage by 8.46%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28821      +/-   ##
===========================================
+ Coverage    46.80%   55.27%   +8.46%     
===========================================
  Files         1122     1122              
  Lines        66777    66828      +51     
===========================================
+ Hits         31255    36936    +5681     
+ Misses       35522    29892    -5630     
Impacted Files Coverage Δ
...nts/doctype/accounts_settings/accounts_settings.py 97.50% <0.00%> (-2.50%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.74% <0.00%> (-0.57%) ⬇️
erpnext/hooks.py 0.00% <0.00%> (ø)
erpnext/regional/saudi_arabia/setup.py 0.00% <0.00%> (ø)
...ext/payroll/doctype/payroll_entry/payroll_entry.py 71.02% <0.00%> (+0.23%) ⬆️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.37% <0.00%> (+0.34%) ⬆️
erpnext/accounts/doctype/account/account.py 71.76% <0.00%> (+0.39%) ⬆️
erpnext/hr/utils.py 74.29% <0.00%> (+0.40%) ⬆️
erpnext/selling/doctype/sales_order/sales_order.py 77.58% <0.00%> (+0.42%) ⬆️
... and 185 more

@nextchamp-saqib nextchamp-saqib merged commit be103ab into frappe:develop Dec 15, 2021
mergify bot pushed a commit that referenced this pull request Dec 15, 2021
nextchamp-saqib pushed a commit that referenced this pull request Dec 22, 2021
)

(cherry picked from commit be103ab)

Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com>
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
fproldan added a commit to fproldan/erpnext that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants