Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reorder patch to fix custom field options #28866

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix: reorder patch to fix custom field options #28866

merged 1 commit into from
Dec 14, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Dec 14, 2021

This is executing way after most v13 patches run which makes it kinda useless.

This should've been added in frappe in first place while adding this validation 馃う

@ankush ankush linked an issue Dec 14, 2021 that may be closed by this pull request
Validations for Custom field option value for Data type fields #28637
Closed
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #28866 (f63aff3) into develop (4984513) will increase coverage by 7.61%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28866      +/-   ##
===========================================
+ Coverage    47.86%   55.47%   +7.61%     
===========================================
  Files         1125     1125              
  Lines        66983    66983              
===========================================
+ Hits         32059    37159    +5100     
+ Misses       34924    29824    -5100
Impacted Files Coverage 螖
...d_supplies/hsn_wise_summary_of_outward_supplies.py 72.38% <酶> (+72.38%) 猬嗭笍
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) 猬囷笍
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) 猬囷笍
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) 猬囷笍
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) 猬囷笍
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) 猬囷笍
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) 猬囷笍
erpnext/portal/product_configurator/utils.py 33.06% <0.00%> (-0.41%) 猬囷笍
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.79% <0.00%> (-0.24%) 猬囷笍
erpnext/stock/doctype/item/item.py 66.62% <0.00%> (+0.26%) 猬嗭笍
... and 174 more

@ankush ankush merged commit 7fd0610 into frappe:develop Dec 14, 2021
mergify bot pushed a commit that referenced this pull request Dec 14, 2021
@ankush
fix: reorder patch to fix custom field options (#28866)
e1c6bd8 
(cherry picked from commit 7fd0610)

# Conflicts:
#	erpnext/patches.txt
@mergify mergify bot mentioned this pull request Dec 14, 2021
Merged
mergify bot pushed a commit that referenced this pull request Dec 14, 2021
@ankush
fix: reorder patch to fix custom field options (#28866)
cc8e8aa 
(cherry picked from commit 7fd0610)

# Conflicts:
#	erpnext/patches.txt
@mergify mergify bot mentioned this pull request Dec 14, 2021
Closed
ankush added a commit that referenced this pull request Dec 14, 2021
@mergify @ankush
fix: reorder patch to fix custom field options (backport #28866)
187a69e 
* fix: reorder patch to fix custom field options (#28866)

(cherry picked from commit 7fd0610)

# Conflicts:
#	erpnext/patches.txt

* fix: resolve conflict

Co-authored-by: Ankush Menat <ankush@frappe.io>
mergify bot added a commit that referenced this pull request Dec 14, 2021
@mergify
fix: reorder patch to fix custom field options (backport #28866)
cdaa804 
* fix: reorder patch to fix custom field options (#28866)

(cherry picked from commit 7fd0610)

# Conflicts:
#	erpnext/patches.txt

* fix: resolve conflict

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 187a69e)
ankush pushed a commit that referenced this pull request Dec 14, 2021
@mergify
fix: reorder patch to fix custom field options (backport #28866)
0d8ad4d 
* fix: reorder patch to fix custom field options (#28866)

(cherry picked from commit 7fd0610)

# Conflicts:
#	erpnext/patches.txt

* fix: resolve conflict

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 187a69e)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@commit-lint commit-lint bot mentioned this pull request Jan 7, 2022
Merged
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@ankush
fix: reorder patch to fix custom field options (frappe#28866)
6a904d9
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@ankush
fix: reorder patch to fix custom field options (frappe#28866)
274701b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validations for Custom field option value for Data type fields
1 participant
@ankush