-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gl-report): group by cost center only if include_dimensions is checked #28883
fix(gl-report): group by cost center only if include_dimensions is checked #28883
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28883 +/- ##
===========================================
- Coverage 57.74% 57.60% -0.14%
===========================================
Files 1110 1110
Lines 67991 67993 +2
===========================================
- Hits 39262 39168 -94
- Misses 28729 28825 +96
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
if
group_by_voucher_consolidated
is checked the ledger entries are differentiated byvoucher_type, voucher_no, account
andcost_center
Cost Center is just another dimension, so it should be treated similarly. Hence ledger entries should be grouped by
cost_center
only ifinclude_dimensions
is checked.