Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gl-report): group by cost center only if include_dimensions is checked #28883

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

nextchamp-saqib
Copy link
Member

if group_by_voucher_consolidated is checked the ledger entries are differentiated by voucher_type, voucher_no, account and cost_center

Cost Center is just another dimension, so it should be treated similarly. Hence ledger entries should be grouped by cost_center only if include_dimensions is checked.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #28883 (b0ba31a) into develop (962dd5e) will decrease coverage by 0.13%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop   #28883      +/-   ##
===========================================
- Coverage    57.74%   57.60%   -0.14%     
===========================================
  Files         1110     1110              
  Lines        67991    67993       +2     
===========================================
- Hits         39262    39168      -94     
- Misses       28729    28825      +96     
Impacted Files Coverage Δ
...t/accounts/report/general_ledger/general_ledger.py 59.59% <83.33%> (+0.27%) ⬆️
...unts/report/purchase_register/purchase_register.py 32.19% <0.00%> (-39.05%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 58.00% <0.00%> (-17.00%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 85.23% <0.00%> (-2.69%) ⬇️
...r/doctype/leave_ledger_entry/leave_ledger_entry.py 90.16% <0.00%> (-1.64%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
...cial_statement/consolidated_financial_statement.py 88.81% <0.00%> (-0.96%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 70.94% <0.00%> (-0.86%) ⬇️
... and 10 more

@nextchamp-saqib nextchamp-saqib changed the title fix(gl-report): group by cost center only if include_dimensions is ch… fix(gl-report): group by cost center only if include_dimensions is checked Dec 15, 2021
@stale
Copy link

stale bot commented Dec 30, 2021

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Dec 30, 2021
@stale stale bot closed this Jan 2, 2022
@stale stale bot removed the inactive label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants