Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch appointment letter content in the same order as template #28968

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

ruchamahabal
Copy link
Member

Problem:

  1. Create an Appointment Letter Template with terms

    image

  2. Create an Appointment Letter with that template. The terms don't get fetched in the same order as the template. The system should follow the same sequence which is in Appointment Letter Template.

    appointment-letter

Fix:

While fetching terms, order by idx so that the same order is followed in all the letters generated using a template.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #28968 (60a3868) into develop (d7148ad) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #28968      +/-   ##
===========================================
+ Coverage    55.49%   55.51%   +0.02%     
===========================================
  Files         1128     1128              
  Lines        67287    67287              
===========================================
+ Hits         37339    37355      +16     
+ Misses       29948    29932      -16     
Impacted Files Coverage Δ
...r/doctype/appointment_letter/appointment_letter.py 0.00% <0.00%> (ø)
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.78% <0.00%> (-0.73%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.84% <0.00%> (-0.56%) ⬇️
erpnext/portal/product_configurator/utils.py 33.06% <0.00%> (-0.41%) ⬇️
erpnext/hr/utils.py 74.29% <0.00%> (-0.41%) ⬇️
... and 14 more

@ruchamahabal ruchamahabal merged commit 92e86f2 into frappe:develop Dec 20, 2021
@ruchamahabal
Copy link
Member Author

@Mergifyio backport version-13-hotfix

mergify bot pushed a commit that referenced this pull request Dec 20, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2021

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant