fix(test): Leave Allocation validation against Leave Application after submit #29005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29005 +/- ##
===========================================
+ Coverage 49.33% 55.61% +6.28%
===========================================
Files 1128 1128
Lines 67291 67291
===========================================
+ Hits 33197 37423 +4226
+ Misses 34094 29868 -4226
|
ruchamahabal
force-pushed
the
fix-leave-alloc
branch
from
a0c4eb7
to
3685ad7
Compare
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
ruchamahabal
added a commit
to ruchamahabal/erpnext
that referenced
this pull request
Dec 27, 2021
…r submit (frappe#29005) * fix(test): Leave Allocation validation against Leave Application after submit * chore: clean-up Leave Allocation tests * fix(test): set holiday list for leave allocation test
Merged
ruchamahabal
added a commit
that referenced
this pull request
Dec 27, 2021
* fix(test): Leave Allocation validation against Leave Application after submit (#29005) * fix(test): Leave Allocation validation against Leave Application after submit * chore: clean-up Leave Allocation tests * fix(test): set holiday list for leave allocation test * fix: flaky HR tests (#29017) * fix(test): use root company in Expense Claim tests * fix(test): set Holiday List for Leave Allocation * fix(test): set Holiday List for company
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
…r submit (frappe#29005) * fix(test): Leave Allocation validation against Leave Application after submit * chore: clean-up Leave Allocation tests * fix(test): set holiday list for leave allocation test
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
…r submit (frappe#29005) * fix(test): Leave Allocation validation against Leave Application after submit * chore: clean-up Leave Allocation tests * fix(test): set holiday list for leave allocation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Test failing as the test data considers days in Feb (edge case): 23/2/2022 - 2/3/2022 (8 days). But the test assumes 11 days (as in a normal month), hence validation error is not raised.
Fix:
Use dynamic leave allocation instead of hardcoded values.