fix: flaky HR tests #29017
Merged
fix: flaky HR tests #29017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ruchamahabal
commented
Dec 24, 2021
•
ruchamahabal
commented
- use root company in Expense Claims tests or else it randomly gives the root company error while creating accounts
- set Holiday List for Leave Allocation test
ruchamahabal
force-pushed
the
fix-flaky-tests
branch
2 times, most recently
from
ee3ae8d
to
6cc95cf
Compare
ruchamahabal
force-pushed
the
fix-flaky-tests
branch
from
6cc95cf
to
d318461
Compare
ruchamahabal
force-pushed
the
fix-flaky-tests
branch
from
145ce56
to
feaeea0
Compare
ruchamahabal
force-pushed
the
fix-flaky-tests
branch
from
feaeea0
to
fb6a40b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #29017 +/- ##
===========================================
+ Coverage 45.62% 55.59% +9.96%
===========================================
Files 1128 1128
Lines 67295 67295
===========================================
+ Hits 30705 37412 +6707
+ Misses 36590 29883 -6707
|
ruchamahabal
added a commit
to ruchamahabal/erpnext
that referenced
this pull request
Dec 27, 2021
* fix(test): use root company in Expense Claim tests * fix(test): set Holiday List for Leave Allocation * fix(test): set Holiday List for company
Merged
ruchamahabal
added a commit
that referenced
this pull request
Dec 27, 2021
* fix(test): Leave Allocation validation against Leave Application after submit (#29005) * fix(test): Leave Allocation validation against Leave Application after submit * chore: clean-up Leave Allocation tests * fix(test): set holiday list for leave allocation test * fix: flaky HR tests (#29017) * fix(test): use root company in Expense Claim tests * fix(test): set Holiday List for Leave Allocation * fix(test): set Holiday List for company
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
* fix(test): use root company in Expense Claim tests * fix(test): set Holiday List for Leave Allocation * fix(test): set Holiday List for company
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
* fix(test): use root company in Expense Claim tests * fix(test): set Holiday List for Leave Allocation * fix(test): set Holiday List for company
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.