refactor(UI): clean up portal pages #29018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumaiya2908
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #29018 +/- ##
===========================================
+ Coverage 63.84% 64.12% +0.27%
===========================================
Files 817 817
Lines 58161 58161
===========================================
+ Hits 37133 37294 +161
+ Misses 21028 20867 -161
|
added 8 commits
December 29, 2021 22:57
The empty states feel too empty. Perhaps a white card with the illustration in the center would be better ?
The sidebar items disappear when i go to any page like
|
|
@marination both the issues are to be fixed in the framework. We can go ahead with this PR if everything else is fine. |
marination
requested review from
marination and
nextchamp-saqib
as code owners
|
@sumaiya2908 can you address the failing linter ? |
|
@marination is there any other test to address for this PR? |
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
@Mergifyio backport version-14-hotfix |
✅ Backports have been created
|
ankush
added
squash
|
Fixed Payment Button Placement Before: After: |
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
* refactor: list view for portal pages * refactor: add align center class * refactor: change footer btn class(primary) * refactor: add order style page * refactor: import order page in website * refactor: remove table elements * fix: preview image height * fix: make string translatable * refactor: change font variables * refactor: order preview bg white * refactor: center align items * fix: breadcrumb padding * refactor: make preview image rounded * refactor: add condition for image container * refactor: change alignment for mobile view * fix: make footer button secondary * refactor: clean code * refactor: code indentantion * refactor: remove space * fix: Payment section cleanup Co-authored-by: Summayya <frappe@Summayyas-MacBook-Air.local> Co-authored-by: Marica <maricadsouza221197@gmail.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> (cherry picked from commit da43a5e)
deepeshgarg007
pushed a commit
that referenced
this pull request
Oct 4, 2022
refactor(UI): clean up portal pages (#29018) * refactor: list view for portal pages * refactor: add align center class * refactor: change footer btn class(primary) * refactor: add order style page * refactor: import order page in website * refactor: remove table elements * fix: preview image height * fix: make string translatable * refactor: change font variables * refactor: order preview bg white * refactor: center align items * fix: breadcrumb padding * refactor: make preview image rounded * refactor: add condition for image container * refactor: change alignment for mobile view * fix: make footer button secondary * refactor: clean code * refactor: code indentantion * refactor: remove space * fix: Payment section cleanup Co-authored-by: Summayya <frappe@Summayyas-MacBook-Air.local> Co-authored-by: Marica <maricadsouza221197@gmail.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> (cherry picked from commit da43a5e) Co-authored-by: Summayya Hashmani <58825865+sumaiya2908@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be merged after this
Before
After
Before
After
Mobile View
Pages Affected