Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests #29051

Merged
merged 4 commits into from
Dec 28, 2021
Merged

fix: tests #29051

merged 4 commits into from
Dec 28, 2021

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Dec 28, 2021 •
edited

image

image

@ruchamahabal ruchamahabal mentioned this pull request Dec 28, 2021
Merged
@codecov
Copy link

codecov bot commented Dec 28, 2021 •
edited

Codecov Report

Merging #29051 (e169405) into develop (27b157d) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29051      +/-   ##
===========================================
- Coverage    55.61%   55.52%   -0.09%     
===========================================
  Files         1128     1128              
  Lines        67345    67345              
===========================================
- Hits         37451    37391      -60     
- Misses       29894    29954      +60
Impacted Files Coverage Δ
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <0.00%> (-25.00%) ⬇️
.../manufacturing/report/bom_explorer/bom_explorer.py 94.44% <0.00%> (-5.56%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 74.79% <0.00%> (-2.44%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.32% <0.00%> (-1.74%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/accounts/deferred_revenue.py 75.87% <0.00%> (-0.88%) ⬇️
erpnext/stock/reorder_item.py 76.92% <0.00%> (-0.86%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 78.05% <0.00%> (-0.09%) ⬇️
... and 13 more

@ruchamahabal ruchamahabal added the Skip Manual Testing The changes in this PR does not require manual testing label Dec 28, 2021
@ruchamahabal ruchamahabal changed the title fix: Miscellaneous tests fix: tests Dec 28, 2021
@ruchamahabal ruchamahabal marked this pull request as ready for review December 28, 2021 11:39
@ruchamahabal ruchamahabal merged commit 88df5ce into frappe:develop Dec 28, 2021
@ruchamahabal
Copy link
Member Author

@Mergifyio backport version-13-hotfix

mergify bot pushed a commit that referenced this pull request Dec 28, 2021
@ruchamahabal
fix: tests (#29051)
3df7063 
* fix(test): create salary slip as per timesheet dates for Project Profitability

* fix(test): reload salary slip before checking for payment days

(cherry picked from commit 88df5ce)
@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2021

backport version-13-hotfix

✅ Backports have been created

@mergify mergify bot mentioned this pull request Dec 28, 2021
Merged
ruchamahabal added a commit that referenced this pull request Dec 28, 2021
@mergify @ruchamahabal
fix: tests (#29051) (#29060)
165114b 
* fix(test): create salary slip as per timesheet dates for Project Profitability

* fix(test): reload salary slip before checking for payment days

(cherry picked from commit 88df5ce)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@ruchamahabal
fix: tests (frappe#29051)
2d2fa94 
* fix(test): create salary slip as per timesheet dates for Project Profitability

* fix(test): reload salary slip before checking for payment days
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@ruchamahabal
fix: tests (frappe#29051)
47660ae 
* fix(test): create salary slip as per timesheet dates for Project Profitability

* fix(test): reload salary slip before checking for payment days
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pateljannat pateljannat Awaiting requested review from pateljannat

Assignees
No one assigned
Labels
Skip Manual Testing The changes in this PR does not require manual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ruchamahabal