fix: broken patches #29067
Merged
fix: broken patches #29067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
saurabh6790
commented
Dec 29, 2021
saurabh6790
commented
ankush
requested changes
Dec 29, 2021
saurabh6790
force-pushed
the
patch-fixes
branch
from
02bc4ea
to
f21c0bc
Compare
|
@ankush fixed suggested changes ! |
|
@saurabh6790 can you fix the linting issues. You'll have to set up pre-commit locally as well. For this you can follow |
saurabh6790
force-pushed
the
patch-fixes
branch
from
f21c0bc
to
950b19e
Compare
saurabh6790
force-pushed
the
patch-fixes
branch
from
950b19e
to
5f72026
Compare
ankush
requested changes
Jan 21, 2022
ankush
reviewed
Jan 21, 2022
with previous query rerunning would've caused all values to become 0.
|
@Mergifyio copy develop |
✅ Pull request copies have been created
|
|
@ankush are you working on this? It's been 27 days now! +1 for adding the check of field type. But I still believe, there is no need of two queries. The field type check and sql case statement will do job for you in one go. |
ankush
added
the
Skip Manual Testing
Added it before adding type check cause re-running could cause the entire column to become 0; best to leave it... it doesn't take much time and it runs one time only. |
ankush
added a commit
that referenced
this pull request
Jan 25, 2022
* chore: patch fixes (cherry picked from commit 8b5b146) # Conflicts: # erpnext/patches/v13_0/make_homepage_products_website_items.py * fix: remove desktop icons while deleting sales reports (cherry picked from commit 5f72026) * refactor: dont ignore dangerous exceptions in patches (cherry picked from commit 0aa1ea8) * fix: make patch kinda idempotent with previous query rerunning would've caused all values to become 0. * chore: conflicts * fix: check type before patching Co-authored-by: Saurabh <saurabh6790@gmail.com> Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.