Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "update cost" should ignore overridden routing times #29154

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Jan 5, 2022

steps to reproduce:

  1. Create a routing
  2. Create a BOM add the routing
  3. Modifying the operations time and save. Operating cost will be correct.
  4. Do "Update cost" it will override the operations time and overall cost will also change.

Expected: operation time should not change when "update cost" is done.

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #29154 (41a1ab8) into develop (962dd5e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29154      +/-   ##
===========================================
+ Coverage    57.74%   57.76%   +0.02%     
===========================================
  Files         1110     1110              
  Lines        67991    67987       -4     
===========================================
+ Hits         39262    39275      +13     
+ Misses       28729    28712      -17     
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/bom/bom.py 86.76% <ø> (-0.09%) ⬇️
...unts/report/purchase_register/purchase_register.py 32.19% <0.00%> (-39.05%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 58.00% <0.00%> (-17.00%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
...cial_statement/consolidated_financial_statement.py 88.81% <0.00%> (-0.96%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-0.86%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 51.36% <0.00%> (-0.46%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.36% <0.00%> (-0.43%) ⬇️
... and 24 more

@ankush ankush marked this pull request as ready for review January 11, 2022 08:48
@ankush ankush merged commit 754596d into frappe:develop Jan 11, 2022
@ankush ankush deleted the bom_op_time branch January 11, 2022 08:50
mergify bot pushed a commit that referenced this pull request Jan 11, 2022
fix: "update cost" should ignore overridden routing times
(cherry picked from commit 754596d)
ankush added a commit that referenced this pull request Jan 11, 2022
)

fix: "update cost" should ignore overridden routing times
(cherry picked from commit 754596d)

Co-authored-by: Ankush Menat <ankush@frappe.io>
KrithiRamani pushed a commit to KrithiRamani/erpnext that referenced this pull request Mar 14, 2022
frappe#29235)

fix: "update cost" should ignore overridden routing times
(cherry picked from commit 754596d)

Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant