Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore cancelled SLEs #29303

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Jan 16, 2022

Affected reports:

  • batch item expiry
  • cogs by item group
  • item-wise reorder level

Other functionality:

  • auto batch selection wasn't ignoring canceled SLEs
  • get_valuation_rate wasn't ignoring canceled SLEs

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #29303 (967ca65) into develop (b0cf619) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #29303   +/-   ##
========================================
  Coverage    57.95%   57.95%           
========================================
  Files         1110     1110           
  Lines        68088    68088           
========================================
  Hits         39463    39463           
  Misses       28625    28625           
Impacted Files Coverage Δ
erpnext/stock/doctype/batch/batch.py 82.23% <ø> (ø)
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <ø> (-25.00%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 97.43% <ø> (ø)
...eorder_level/itemwise_recommended_reorder_level.py 94.33% <ø> (ø)
erpnext/stock/stock_ledger.py 85.42% <ø> (-0.37%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...unts/report/purchase_register/purchase_register.py 73.28% <0.00%> (-6.85%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 75.00% <0.00%> (-3.00%) ⬇️
... and 24 more

@ankush ankush marked this pull request as ready for review January 16, 2022 13:19
@ankush ankush added the Skip Manual Testing The changes in this PR does not require manual testing label Jan 16, 2022
@ankush ankush added this to the v13.19 milestone Jan 16, 2022
@ankush ankush merged commit 82ea958 into frappe:develop Jan 16, 2022
mergify bot pushed a commit that referenced this pull request Jan 16, 2022
(cherry picked from commit 82ea958)
ankush added a commit that referenced this pull request Jan 16, 2022
(cherry picked from commit 82ea958)

Co-authored-by: Ankush Menat <ankush@frappe.io>
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
KrithiRamani pushed a commit to KrithiRamani/erpnext that referenced this pull request Mar 14, 2022
(cherry picked from commit 82ea958)

Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant