fix(patch): sle.serial_no = "\n" causes incorrect queue #29306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens due to old data.
ankush
requested review from
deepeshgarg007,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
ankush
added
the
Skip Manual Testing
Codecov Report
@@ Coverage Diff @@
## develop #29306 +/- ##
===========================================
- Coverage 57.95% 57.89% -0.07%
===========================================
Files 1110 1110
Lines 68088 68089 +1
===========================================
- Hits 39463 39419 -44
- Misses 28625 28670 +45
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2022
This happens due to old data. (cherry picked from commit 66bf21f)
ankush
added a commit
that referenced
this pull request
Jan 16, 2022
ankush
removed
the
Skip Manual Testing
KrithiRamani
pushed a commit
to KrithiRamani/erpnext
that referenced
this pull request
Mar 14, 2022
frappe#29309) This happens due to old data. (cherry picked from commit 66bf21f) Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extending the previous patch to clean up
"\n"in serial_no field.