Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update status on visit cancel #29389

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

noahjacob
Copy link
Contributor

Issue

  • On cancelling the Visit, the status would not update in the linked Schedule.

cancel_bug

Fix

cancel_fix

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #29389 (17ac660) into develop (f5ed0c8) will increase coverage by 0.12%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop   #29389      +/-   ##
===========================================
+ Coverage    57.87%   57.99%   +0.12%     
===========================================
  Files         1091     1091              
  Lines        67894    67897       +3     
===========================================
+ Hits         39292    39376      +84     
+ Misses       28602    28521      -81     
Impacted Files Coverage Δ
...nce/doctype/maintenance_visit/maintenance_visit.py 60.24% <91.66%> (+8.99%) ⬆️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 89.13% <0.00%> (-2.18%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
erpnext/controllers/stock_controller.py 89.69% <0.00%> (-1.01%) ⬇️
... and 31 more

@noahjacob noahjacob merged commit 11c9a5a into frappe:develop Jan 21, 2022
mergify bot pushed a commit that referenced this pull request Jan 21, 2022
* fix: update status on cancelling visit

* test: updated test for cancelling visits

(cherry picked from commit 11c9a5a)
mergify bot pushed a commit that referenced this pull request Jan 21, 2022
* fix: update status on cancelling visit

* test: updated test for cancelling visits

(cherry picked from commit 11c9a5a)
noahjacob added a commit that referenced this pull request Jan 21, 2022
* fix: update status on cancelling visit

* test: updated test for cancelling visits

(cherry picked from commit 11c9a5a)

Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
noahjacob added a commit that referenced this pull request Jan 21, 2022
* fix: update status on cancelling visit

* test: updated test for cancelling visits

(cherry picked from commit 11c9a5a)

Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
KrithiRamani pushed a commit to KrithiRamani/erpnext that referenced this pull request Mar 14, 2022
* fix: update status on cancelling visit

* test: updated test for cancelling visits

(cherry picked from commit 11c9a5a)

Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion statuses not updated appropriately in Maintenance Schedules upon cancellation of maintenance visits
1 participant