Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Employee Onboarding and Separation UX #29504

Merged
merged 8 commits into from
Jan 29, 2022

Conversation

ruchamahabal
Copy link
Member

Closes #29470

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 29, 2022
@ruchamahabal ruchamahabal removed the needs-tests This PR needs automated unit-tests. label Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #29504 (570ca0c) into develop (43bd88e) will increase coverage by 5.97%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29504      +/-   ##
===========================================
+ Coverage    52.40%   58.38%   +5.97%     
===========================================
  Files         1091     1091              
  Lines        67907    67913       +6     
===========================================
+ Hits         35587    39649    +4062     
+ Misses       32320    28264    -4056     
Impacted Files Coverage Δ
erpnext/hr/doctype/job_offer/job_offer.py 82.92% <ø> (ø)
...rpnext/controllers/employee_boarding_controller.py 84.26% <100.00%> (+7.25%) ⬆️
...doctype/employee_onboarding/employee_onboarding.py 92.68% <100.00%> (+54.84%) ⬆️
...unts/report/purchase_register/purchase_register.py 34.24% <0.00%> (-45.90%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <0.00%> (-25.00%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 58.00% <0.00%> (-20.00%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 97.67% <0.00%> (-2.33%) ⬇️
... and 173 more

@ruchamahabal ruchamahabal merged commit 36882f3 into frappe:develop Jan 29, 2022
@ruchamahabal ruchamahabal deleted the fix-emp-boarding-ux branch January 29, 2022 09:57
@ruchamahabal
Copy link
Member Author

@Mergifyio backport version-14-beta-pre-release

mergify bot pushed a commit that referenced this pull request Jan 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2022

backport version-14-beta-pre-release

✅ Backports have been created

ruchamahabal added a commit that referenced this pull request Jan 29, 2022
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
@Ponyooooo
Copy link

will this fix be included on the v13 so that we can utilize and test the revisions? Right now the HR feature for the employee onboarding and separation are both not used because of the issues raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Employee Onboarding & Separation Improvements
2 participants