-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Employee Onboarding and Separation UX #29504
Merged
ruchamahabal
merged 8 commits into
frappe:develop
from
ruchamahabal:fix-emp-boarding-ux
Jan 29, 2022
Merged
fix: Employee Onboarding and Separation UX #29504
ruchamahabal
merged 8 commits into
frappe:develop
from
ruchamahabal:fix-emp-boarding-ux
Jan 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set employee from job applicant if already exists
ruchamahabal
requested review from
ankush,
deepeshgarg007,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
January 29, 2022 09:29
ruchamahabal
removed request for
rohitwaghchaure,
ankush,
nextchamp-saqib,
marination,
pateljannat and
deepeshgarg007
January 29, 2022 09:30
Codecov Report
@@ Coverage Diff @@
## develop #29504 +/- ##
===========================================
+ Coverage 52.40% 58.38% +5.97%
===========================================
Files 1091 1091
Lines 67907 67913 +6
===========================================
+ Hits 35587 39649 +4062
+ Misses 32320 28264 -4056
|
@Mergifyio backport version-14-beta-pre-release |
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2022
(cherry picked from commit 36882f3)
✅ Backports have been created
|
ruchamahabal
added a commit
that referenced
this pull request
Jan 29, 2022
will this fix be included on the v13 so that we can utilize and test the revisions? Right now the HR feature for the employee onboarding and separation are both not used because of the issues raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29470