Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple CRM fixes #29507

Merged
merged 5 commits into from
Jan 29, 2022
Merged

fix: multiple CRM fixes #29507

merged 5 commits into from
Jan 29, 2022

Conversation

anupamvs
Copy link
Contributor

Issues-

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. selling labels Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022 •
edited

Codecov Report

Merging #29507 (757cc3f) into develop (cc4b404) will increase coverage by 10.41%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##           develop   #29507       +/-   ##
============================================
+ Coverage    48.19%   58.60%   +10.41%     
============================================
  Files         1091     1091               
  Lines        68006    68006               
============================================
+ Hits         32776    39858     +7082     
+ Misses       35230    28148     -7082
Impacted Files Coverage Δ
erpnext/crm/doctype/crm_settings/crm_settings.py 0.00% <0.00%> (ø)
erpnext/crm/doctype/opportunity/opportunity.py 70.42% <ø> (-0.28%) ⬇️
...lling/doctype/selling_settings/selling_settings.py 100.00% <100.00%> (ø)
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
.../manufacturing/report/bom_explorer/bom_explorer.py 94.44% <0.00%> (-5.56%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 86.84% <0.00%> (-2.64%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/support/doctype/issue/issue.py 64.56% <0.00%> (-0.98%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 72.72% <0.00%> (+0.21%) ⬆️
erpnext/setup/doctype/company/company.py 73.01% <0.00%> (+0.31%) ⬆️
... and 240 more

@anupamvs anupamvs removed selling needs-tests This PR needs automated unit-tests. labels Jan 29, 2022
@anupamvs
Copy link
Contributor Author

@Mergifyio backport version-14-beta-pre-release

@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2022

backport version-14-beta-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@anupamvs anupamvs merged commit 925eca0 into frappe:develop Jan 29, 2022
mergify bot pushed a commit that referenced this pull request Jan 29, 2022
@anupamvs
fix: multiple CRM fixes (#29507)
b00fb12 
* fix: multiple CRM fixes

(cherry picked from commit 925eca0)
@mergify mergify bot mentioned this pull request Jan 29, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2022

backport version-14-beta-pre-release

✅ Backports have been created

anupamvs added a commit that referenced this pull request Jan 31, 2022
@mergify @anupamvs
fix: multiple CRM fixes (#29507) (#29513)
56edbe7 
* fix: multiple CRM fixes

(cherry picked from commit 925eca0)

Co-authored-by: Anupam Kumar <anupamvns0099@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@pateljannat pateljannat Awaiting requested review from pateljannat

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@anupamvs