Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch image form item #29523

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix: fetch image form item #29523

merged 1 commit into from
Jan 31, 2022

Conversation

hrwX
Copy link
Contributor

@hrwX hrwX commented Jan 30, 2022 •
edited

  • Fetches Item's image while creating an Asset
  • Depends of frappe/#15799

@ankush ankush merged commit 3193222 into frappe:develop Jan 31, 2022
@barredterra
Copy link
Collaborator

@Mergifyio backport version-13-hotfix

mergify bot pushed a commit that referenced this pull request Feb 1, 2022
@hrwX
fix: fetch image form item (#29523)
d5478d0 
(cherry picked from commit 3193222)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.json
@mergify mergify bot mentioned this pull request Feb 1, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

backport version-13-hotfix

✅ Backports have been created

ankush pushed a commit that referenced this pull request Feb 8, 2022
@mergify @hrwX @barredterra
fix: fetch image form item (backport #29523) (#29571)
e69f70f 
* fix: fetch image form item (#29523)

(cherry picked from commit 3193222)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.json

* chore: resolve merge conflicts

Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
s-aga-r pushed a commit to s-aga-r/erpnext that referenced this pull request Feb 15, 2022
@mergify @hrwX
@barredterra @s-aga-r
fix: fetch image form item (backport frappe#29523) (frappe#29571)
05429d0 
* fix: fetch image form item (frappe#29523)

(cherry picked from commit 3193222)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.json

* chore: resolve merge conflicts

Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
@rohitwaghchaure rohitwaghchaure mentioned this pull request Feb 21, 2022
Merged
KrithiRamani pushed a commit to KrithiRamani/erpnext that referenced this pull request Mar 14, 2022
@mergify @hrwX
@barredterra @KrithiRamani
fix: fetch image form item (backport frappe#29523) (frappe#29571)
6d2e185 
* fix: fetch image form item (frappe#29523)

(cherry picked from commit 3193222)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.json

* chore: resolve merge conflicts

Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hrwX @barredterra @ankush