fix(pos): creating pos returns resets pricing rules & discounts #30935
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2022
(cherry picked from commit 867494e)
hrwX
pushed a commit
to hrwX/erpnext
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The pricing rules/discounts are reset if you create a POS Return from POS view for a POS Invoice that has pricing rules/discounts applied
Why:
This doesn't happens when returns are created from Form View, that is because links are not triggered for a new doc from Form View
Since the links are triggered in POS view when a new doc is loaded, the Price List link is triggered which leads to resetting of pricing rules