Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(india): e-invoice eligibility if company gstin is not configured #31247

Merged

Conversation

nextchamp-saqib
Copy link
Member

Exclude Invoices from e-invoicing if the Company GSTIN is not configured in the E-Invoice Settings

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #31247 (25aa17e) into develop (9fb7b49) will increase coverage by 0.38%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #31247      +/-   ##
===========================================
+ Coverage    63.18%   63.56%   +0.38%     
===========================================
  Files          985      986       +1     
  Lines        67283    67421     +138     
===========================================
+ Hits         42510    42857     +347     
+ Misses       24773    24564     -209     
Impacted Files Coverage Δ
erpnext/regional/india/e_invoice/utils.py 38.53% <100.00%> (-1.73%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
...e_request/pending_so_items_for_purchase_request.py 85.10% <0.00%> (-12.77%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
erpnext/stock/reorder_item.py 74.16% <0.00%> (-3.62%) ⬇️
erpnext/hr/doctype/job_applicant/job_applicant.py 63.93% <0.00%> (-3.28%) ⬇️
erpnext/utilities/activation.py 62.85% <0.00%> (-2.86%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-2.41%) ⬇️
... and 69 more

@nextchamp-saqib nextchamp-saqib merged commit fb4f8d8 into frappe:develop Jun 8, 2022
mergify bot pushed a commit that referenced this pull request Jun 8, 2022
mergify bot pushed a commit that referenced this pull request Jun 8, 2022
…31247)

(cherry picked from commit fb4f8d8)

# Conflicts:
#	erpnext/regional/india/e_invoice/utils.py
deepeshgarg007 added a commit that referenced this pull request Jun 17, 2022
…-31247

fix(india): e-invoice eligibility if company gstin is not configured (backport #31247)
frappe-pr-bot pushed a commit that referenced this pull request Jun 21, 2022
## [13.34.1](v13.34.0...v13.34.1) (2022-06-21)

### Bug Fixes

* Conversion rate validation for multi-currency invoices ([4186aaf](4186aaf))
* **india:** e-invoice eligibility if company gstin is not configured ([#31247](#31247)) ([7696ae4](7696ae4))
* internal transfer GLE validation ([8a4cd2a](8a4cd2a))
* Merge Conflicts ([0f3a02d](0f3a02d))
* Pick Template BOM if variant BOM absent in WO popup from SO ([7c35887](7c35887))
* Quotation lost update ([3b9f943](3b9f943))
* Spelling mistake in quotation depend on (backport [#31362](#31362)) ([#31363](#31363)) ([ebcdaf7](ebcdaf7))
* transaction date gets unset in material request ([#31387](#31387)) ([4e2ed6f](4e2ed6f)), closes [#31327](#31327)
* UOM handling for transaction without item (backport [#31389](#31389)) ([#31391](#31391)) ([051e5cd](051e5cd))

### Performance Improvements

* GLE reposting with progress and chunking (backport [#31343](#31343)) ([#31373](#31373)) ([f19ed0b](f19ed0b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant