Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up product bundle client side code #31455

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Jun 27, 2022

  • Remove deprecated CUR_FRM scripts
  • Remove client-side fetches and move it to doctype schema.

Also resolves the issue of bulk pasting item codes and not auto-populating item info.

ref: ISS-22-23-00838

- Remove deprecated CUR_FRM scripts
- Remove client side fetches and move it to doctype schema
@ankush ankush changed the title refactor: clean up product bundle cient side code refactor: clean up product bundle client side code Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #31455 (035ef03) into develop (173588e) will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #31455      +/-   ##
===========================================
+ Coverage    63.55%   63.73%   +0.18%     
===========================================
  Files          986      986              
  Lines        67854    67854              
===========================================
+ Hits         43122    43245     +123     
+ Misses       24732    24609     -123     
Impacted Files Coverage Δ
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-42.77%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-19.81%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 89.02% <0.00%> (-2.44%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 88.88% <0.00%> (-1.86%) ⬇️
erpnext/stock/doctype/item_price/item_price.py 92.98% <0.00%> (-1.76%) ⬇️
erpnext/stock/reorder_item.py 73.33% <0.00%> (-1.67%) ⬇️
erpnext/portal/utils.py 27.69% <0.00%> (-1.54%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 49.25% <0.00%> (-1.50%) ⬇️
... and 30 more

@ankush ankush merged commit 20dac08 into frappe:develop Jun 27, 2022
mergify bot pushed a commit that referenced this pull request Jun 27, 2022
refactor: clean up product bundle cient side code

- Remove deprecated CUR_FRM scripts
- Remove client side fetches and move it to doctype schema

(cherry picked from commit 20dac08)
ankush added a commit that referenced this pull request Jun 27, 2022
…31456)

refactor: clean up product bundle client side code (#31455)

refactor: clean up product bundle cient side code

- Remove deprecated CUR_FRM scripts
- Remove client side fetches and move it to doctype schema

(cherry picked from commit 20dac08)

Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant