Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mentions in notes, workspace links, no-of-employees field type and report fixes #31678

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

nabinhait
Copy link
Member

@nabinhait nabinhait commented Jul 22, 2022

  • Ability to mention users in notes and notify them via email
  • CRM workspace
    • Rearranged workspace links
    • Added links for Prospect, CRM Settings and Sales Stage
  • Made no-of-employees field type select
  • Fixed issue related to Supplier Quotation and RFQ creation link from Opportunity
  • Added dashboard in lead
  • Fixed issue in Opportunity Summary by Sales Stage report

Depends on frappe/frappe#17592

Fixes #31635 #29739 #29245

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #31678 (02dd174) into develop (cdec6f6) will increase coverage by 0.21%.
The diff coverage is 63.63%.

@@             Coverage Diff             @@
##           develop   #31678      +/-   ##
===========================================
+ Coverage    63.12%   63.33%   +0.21%     
===========================================
  Files          813      813              
  Lines        57510    57510              
===========================================
+ Hits         36305    36426     +121     
+ Misses       21205    21084     -121     
Impacted Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 72.44% <ø> (+1.11%) ⬆️
..._sales_stage/opportunity_summary_by_sales_stage.py 75.78% <55.55%> (-0.38%) ⬇️
erpnext/crm/utils.py 69.23% <100.00%> (+0.53%) ⬆️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 81.96% <0.00%> (-8.20%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-8.19%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 84.65% <0.00%> (-3.26%) ⬇️
erpnext/stock/reorder_item.py 73.33% <0.00%> (-1.67%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 60.90% <0.00%> (-0.91%) ⬇️
erpnext/assets/doctype/asset/asset.py 81.92% <0.00%> (-0.83%) ⬇️
... and 27 more

@nabinhait nabinhait merged commit 67fefa3 into frappe:develop Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V14 CRM Issues
1 participant