Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explicitly commit "log_error" since its getting called during GET request #31952

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

surajshetty3416
Copy link
Member

Commit statement used to be there before but was removed via 548afba#diff-8f7b55c81666efa69d5742ac574bccbc8d81668eacbac4ce2782d28a166fbaa1L30

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 24, 2022
@surajshetty3416 surajshetty3416 added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Aug 24, 2022
@ankush ankush merged commit 122f1c0 into frappe:develop Aug 24, 2022
mergify bot pushed a commit that referenced this pull request Aug 24, 2022
ankush pushed a commit that referenced this pull request Aug 24, 2022
…T request (backport #31952) (#31953)

fix: Explicitly commit "log_error" since its getting called during GET request (#31952)

(cherry picked from commit 122f1c0)

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 30, 2022
## [14.0.3](v14.0.2...v14.0.3) (2022-08-30)

### Bug Fixes

* AD not getting copied from SCO while creating a SE (backport [#32004](#32004)) ([#32007](#32007)) ([cee867f](cee867f))
* Add docstatus filter for voucher_no in Repost Item Valuation ([309da96](309da96))
* add validation for PO in Stock Entry (backport [#31974](#31974)) ([#31975](#31975)) ([4d8ced6](4d8ced6))
* default supplier not set in the PP ([4cf9fb0](4cf9fb0))
* display amount in account currency if party is supplied ([15915d7](15915d7))
* Explicitly commit "log_error" since its getting called during GET request (backport [#31952](#31952)) ([#31953](#31953)) ([362976f](362976f))
* gl entries for asset repair ([f0f7afa](f0f7afa))
* lost quotation not to expired ([8717235](8717235))
* material request connection on work order ([193502c](193502c))
* **patch:** update sla doctype directly (backport [#32014](#32014)) ([#32015](#32015)) ([1b5a1cb](1b5a1cb))
* permissions for Task Type ([#32016](#32016)) ([7ca1beb](7ca1beb))
* Purchase Order creation from Sales Order ([39ff0cc](39ff0cc))
* Purposes not set ([94ebfa7](94ebfa7))
* restrict party types to Supplier/Customer for AR/AP report ([c407d1e](c407d1e))
* Rounded total for cash and non trade discount invoices ([6c4fcd8](6c4fcd8))
* Route condition set for stock ledger (backport [#31935](#31935)) ([#31945](#31945)) ([a7d23ab](a7d23ab))
@barredterra barredterra mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants