Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tab Breaks in all Sales and Purchase cycle transactions #32408

Merged
merged 9 commits into from
Oct 11, 2022

Conversation

nabinhait
Copy link
Member

@nabinhait nabinhait commented Sep 28, 2022

Tabs introduced in the following documents:

  • Quotation
  • Sales Order
  • Delivery Note
  • Sales Invoice
  • Material Request
  • Supplier Quotation
  • Purchase Order
  • Purchase Receipt
  • Purchase Invoice

Tab Pattern
sales_invoice_with_tabs

no-docs

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #32408 (e71c417) into develop (b99b2b7) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32408      +/-   ##
===========================================
+ Coverage    64.05%   64.08%   +0.02%     
===========================================
  Files          817      817              
  Lines        58229    58229              
===========================================
+ Hits         37299    37316      +17     
+ Misses       20930    20913      -17     
Impacted Files Coverage Δ
erpnext/regional/united_arab_emirates/setup.py 100.00% <ø> (ø)
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...unts/report/purchase_register/purchase_register.py 71.71% <0.00%> (-5.27%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 86.88% <0.00%> (-3.28%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 74.25% <0.00%> (-2.98%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 89.13% <0.00%> (-2.18%) ⬇️
...cial_statement/consolidated_financial_statement.py 88.58% <0.00%> (-1.86%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.74% <0.00%> (-1.86%) ⬇️
... and 24 more

@rtdany10
Copy link
Contributor

@nabinhait the more info tab seems to be cluttered in the GIF

Copy link
Member

@deepeshgarg007 deepeshgarg007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Got this error when I tried to create a new Quotation, some depends_on expression is invalid

image

  1. The middle column remains empty which looks a bit weird, this is seen in all sales and purchase transactions, maybe move the net weight field there or use just two column layout for this section

Screenshot 2022-10-05 at 4 22 32 PM

  1. This same is also seen in the items section in some transactions, the latter one in Purchase Order looks better

Screenshot 2022-10-05 at 4 31 25 PM

Screenshot 2022-10-05 at 5 03 53 PM

  1. Line break missing for totals section in PO

Screenshot 2022-10-05 at 5 11 09 PM

  1. "More Information" and "Additional Information" instead of "More Info" and "Additional Info"
  2. One general concern is that this messes up some of the regional custom field ordering that is created via custom apps which we can control and fix to some extent, the user-created custom fields will just have to be fixed manually

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 38b34f2 into frappe:develop Oct 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2022

backport version-14-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 12, 2022
…-32408

feat: Tab Breaks in all Sales and Purchase cycle transactions (backport #32408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants