-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tab Breaks in all Sales and Purchase cycle transactions #32408
Merged
deepeshgarg007
merged 9 commits into
frappe:develop
from
nabinhait:sales-purchase-tab-break
Oct 11, 2022
Merged
feat: Tab Breaks in all Sales and Purchase cycle transactions #32408
deepeshgarg007
merged 9 commits into
frappe:develop
from
nabinhait:sales-purchase-tab-break
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32408 +/- ##
===========================================
+ Coverage 64.05% 64.08% +0.02%
===========================================
Files 817 817
Lines 58229 58229
===========================================
+ Hits 37299 37316 +17
+ Misses 20930 20913 -17
|
282ec86
to
3840319
Compare
@nabinhait the more info tab seems to be cluttered in the GIF |
deepeshgarg007
requested changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Got this error when I tried to create a new Quotation, some
depends_on
expression is invalid
- The middle column remains empty which looks a bit weird, this is seen in all sales and purchase transactions, maybe move the net weight field there or use just two column layout for this section
- This same is also seen in the items section in some transactions, the latter one in Purchase Order looks better
- Line break missing for totals section in PO
- "More Information" and "Additional Information" instead of "More Info" and "Additional Info"
- One general concern is that this messes up some of the regional custom field ordering that is created via custom apps which we can control and fix to some extent, the user-created custom fields will just have to be fixed manually
49f0baa
to
e71c417
Compare
@Mergifyio backport version-14-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Oct 12, 2022
…-32408 feat: Tab Breaks in all Sales and Purchase cycle transactions (backport #32408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs introduced in the following documents:
Tab Pattern
![sales_invoice_with_tabs](https://user-images.githubusercontent.com/836784/192799624-8fb13860-3869-4303-8879-14ba68cb45fd.gif)
no-docs