Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add items field label #34860

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Apr 14, 2023

Source / Ref: ISS-23-24-00171

Problem: Since the Label was removed in #32408, when the user tries to download the template (Data Import) the label comes as None.

Changes: Add items field Label in Purchase Order, Supplier Quotation and Quotation.

Before:

image

image

After:

image

image

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Apr 14, 2023
@s-aga-r s-aga-r marked this pull request as ready for review April 14, 2023 11:58
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #34860 (a78b4be) into develop (e4f152a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34860      +/-   ##
===========================================
- Coverage    63.86%   63.86%   -0.01%     
===========================================
  Files          810      810              
  Lines        59745    59745              
===========================================
- Hits         38159    38158       -1     
- Misses       21586    21587       +1     

see 2 files with indirect coverage changes

@surajshetty3416 surajshetty3416 changed the title chore: add items field label fix: add items field label Apr 17, 2023
@s-aga-r s-aga-r merged commit a7c5b33 into frappe:develop Apr 18, 2023
1 check passed
s-aga-r added a commit that referenced this pull request Apr 18, 2023
…-34860

fix: add items field label (backport #34860)
@s-aga-r s-aga-r added bug and removed backport version-14-hotfix backport to version 14 labels Apr 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant