fix: (bulk transaction) key error and better error logging #32445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32445 +/- ##
===========================================
+ Coverage 63.90% 63.96% +0.05%
===========================================
Files 817 817
Lines 58178 58161 -17
===========================================
+ Hits 37181 37205 +24
+ Misses 20997 20956 -41
|
ankush
approved these changes
Oct 3, 2022
ankush
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
* fix: (bulk transaction) key error and better error logging * chore: pre-commit * chore: linter - missing comma (cherry picked from commit 9105515)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [14.2.2](v14.2.1...v14.2.2) (2022-10-04) ### Bug Fixes * (bulk transaction) key error and better error logging (backport [#32445](#32445)) ([#32463](#32463)) ([7a80385](7a80385)) * add non-stock item filter for `fg_item` in PO ([11f9279](11f9279)) * add validation for non-stock item in SCR ([793fa18](793fa18)) * asset requiring maintenance sold status and added test [v14-hotfix] ([c0a141b](c0a141b)) * asset tests ([6710337](6710337)) * calculate depreciation properly on asset sale entry and scrap entry ([f5f13c4](f5f13c4)) * Create accounting dimension fields in asset capitalization ([9ec0d10](9ec0d10)) * Disbursement Account in patch to update old loans ([0973989](0973989)) * don't allow to update `Maintain Stock` if the item has a `BOM` ([e5d1f59](e5d1f59)) * fetch swift_number in payment_request ([f09222a](f09222a)) * fix restore asset value after depreciation ([8605245](8605245)) * fixes query builder order by issue in postgres (backport [#32441](#32441)) ([#32465](#32465)) ([8851826](8851826)) * Incorrect TCS amount deducted in Sales Invoice ([4d51d73](4d51d73)) * Item details fetching on making transaction from item dashboard ([db60299](db60299)) * not able to return sold expired batches ([9c56a5f](9c56a5f)) * payment request make bank field Link instead of Read Only ([c8c0f34](c8c0f34)) * pick list picked-qty for batch item ([32107c4](32107c4)) * refactor asset capitilization ([bad3b33](bad3b33)) * searchfields as per customize form not working for Item ([f167abb](f167abb)) * show `Make Purchase Invoice` button based on permission ([fd86876](fd86876)) * supplied items added twice in Stock Entry ([d91ac5e](d91ac5e)) * test_scrap_asset ([fd232d1](fd232d1)) * typo in sales_register's filter mode_of_payment (backport [#32371](#32371)) ([#32446](#32446)) ([1918b5c](1918b5c)) * update with new Frappe color. fix [#32455](#32455) ([#32456](#32456)) ([3e7582f](3e7582f)) ### Reverts * Revert "fix: fetch swift_number in payment_request" ([d3c151f](d3c151f))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32442