Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deduplicate Payment Ledger on Item value repost #32567

Merged
merged 2 commits into from
Oct 13, 2022
Merged

fix: deduplicate Payment Ledger on Item value repost #32567

merged 2 commits into from
Oct 13, 2022

Conversation

ruthra-kumar
Copy link
Member

Upon Item value repost, duplicate entries are created in Payment Ledger which affect the Invoice outstanding. Fixing in this change.

  1. Invoice: Screenshot 2022-10-11 at 5 03 20 PM
  2. Backdated stock entry: Screenshot 2022-10-11 at 2 58 11 PM
  3. Repost triggered from [2]: Screenshot 2022-10-11 at 2 58 38 PM
  4. Duplicate PLE entries: Screenshot 2022-10-11 at 2 58 01 PM
  5. Incorrect invoice outstanding: Screenshot 2022-10-11 at 4 55 40 PM

@ruthra-kumar ruthra-kumar linked an issue Oct 11, 2022 that may be closed by this pull request
Invoice outstanding amount is higher than invoice amount #32471
Closed
@ruthra-kumar
Copy link
Member Author

Will create a separate utility to fix affected data

@ruthra-kumar ruthra-kumar force-pushed the remove_duplicate_ple_on_item_value_repost branch from 426277c to 1c10622 Compare October 12, 2022 10:05
@ruthra-kumar ruthra-kumar force-pushed the remove_duplicate_ple_on_item_value_repost branch from 1c10622 to eb81936 Compare October 12, 2022 10:39
@ruthra-kumar ruthra-kumar merged commit 2d0217a into frappe:develop Oct 13, 2022
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify mergify bot mentioned this pull request Oct 13, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2022

backport version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Oct 13, 2022
@ruthra-kumar
Merge pull request #32592 from frappe/mergify/bp/version-14-hotfix/pr…
a012c55 
…-32567

fix: deduplicate Payment Ledger on Item value repost (backport #32567)
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Oct 28, 2022
@ruthra-kumar
fest: Repost Payment Ledger entries for vouchers
f77a95c 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
@ruthra-kumar ruthra-kumar mentioned this pull request Oct 28, 2022
Merged
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Oct 29, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
214e5b7 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Oct 29, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
473c14b 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Oct 29, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
2f56b28 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Oct 30, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
719fadc 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Oct 31, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
2b3d2fa 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Nov 2, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
53770d0 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Nov 6, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
b787714 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Nov 6, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
d1a5ac2 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Nov 7, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
272427f 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Nov 8, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
2047c1b 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Nov 8, 2022
@ruthra-kumar
feat: Repost Payment Ledger entries for vouchers
0448c0f 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-frappe#32567
mergify bot pushed a commit that referenced this pull request Nov 9, 2022
@ruthra-kumar @mergify
feat: Repost Payment Ledger entries for vouchers
de59b50 
primarily intended to manually correct PLE entries for vouchers
affected by Item Value repost-#32567

(cherry picked from commit 0448c0f)
@ruthra-kumar ruthra-kumar deleted the remove_duplicate_ple_on_item_value_repost branch June 14, 2023 16:05
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoice outstanding amount is higher than invoice amount
1 participant
@ruthra-kumar