Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect qty in material request created from PP #32654

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  1. Create an Item and set default UOM as "Nos" and purchase uom as "BOX"
  2. Set UOM conversion factor as 1 BOX = 10 Nos in the item
  3. Make BOM with above item as Raw Material, and set ratio as 1:1 (1 FG Item : 1 Raw Material)
  4. Make Production plan for FG Item with Qty to manufacture as 10
  5. System will suggest to create Material Request for Raw Material with qty as 10 Nos
  6. Create Material request from production plan
  7. In material request system will set the UOM as BOX and not Nos because BOX is default purchase UOM
  8. But system will set quantity as per Nos as 10 and not as per BOX as 1
  9. Due to this behaviour, the qty in the material request is showing as 100 Nos and not 10 Nos.

Screenshot 2022-10-19 at 7 17 00 PM

After Fix
Screenshot 2022-10-19 at 7 12 19 PM

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #32654 (4d5ef72) into develop (f844097) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #32654   +/-   ##
========================================
  Coverage    63.72%   63.72%           
========================================
  Files          816      816           
  Lines        58310    58314    +4     
========================================
+ Hits         37156    37160    +4     
  Misses       21154    21154           
Impacted Files Coverage Δ
...cturing/doctype/production_plan/production_plan.py 74.83% <100.00%> (+0.32%) ⬆️
erpnext/stock/stock_ledger.py 89.95% <0.00%> (-0.32%) ⬇️
...xt/accounts/doctype/payment_entry/payment_entry.py 72.79% <0.00%> (ø)
erpnext/manufacturing/doctype/job_card/job_card.py 71.32% <0.00%> (+0.23%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant