Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect fix of conversion factor in PP #32947

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue
The fix #32654 was related to Material request but the quantity in production plan is still incorrect

After Fix

The fix will take care of both Production Plan as well Material Request

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #32947 (490b0e3) into develop (8581b78) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32947      +/-   ##
===========================================
+ Coverage    63.81%   63.83%   +0.02%     
===========================================
  Files          817      819       +2     
  Lines        58510    58723     +213     
===========================================
+ Hits         37338    37488     +150     
- Misses       21172    21235      +63     
Impacted Files Coverage Δ
...cturing/doctype/production_plan/production_plan.py 74.87% <100.00%> (+0.04%) ⬆️
...e_commerce/variant_selector/item_variants_cache.py 76.38% <0.00%> (-1.39%) ⬇️
erpnext/stock/doctype/batch/batch.py 83.33% <0.00%> (-0.62%) ⬇️
...e/subcontracting_receipt/subcontracting_receipt.py 92.30% <0.00%> (-0.60%) ⬇️
erpnext/stock/doctype/pick_list/pick_list.py 76.74% <0.00%> (-0.08%) ⬇️
erpnext/controllers/stock_controller.py 92.08% <0.00%> (-0.04%) ⬇️
erpnext/hooks.py 100.00% <0.00%> (ø)
erpnext/setup/doctype/company/company.py 73.50% <0.00%> (ø)
...t/manufacturing/doctype/workstation/workstation.py 90.16% <0.00%> (ø)
.../accounts/doctype/bank_guarantee/bank_guarantee.py 0.00% <0.00%> (ø)
... and 19 more

@rohitwaghchaure rohitwaghchaure merged commit 91fad19 into frappe:develop Nov 15, 2022
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Nov 15, 2022
rohitwaghchaure added a commit that referenced this pull request Nov 15, 2022
…-32947

fix: incorrect fix of conversion factor in PP (backport #32947)
rohitwaghchaure added a commit that referenced this pull request Nov 19, 2022
…-32947

fix: incorrect fix of conversion factor in PP (backport #32947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant