Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search field not working for customer, supplier #32693

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

Set searchfield as "customer_group" for the customer doctype, still can see other fields in the customer dropdown

image

Screenshot 2022-10-24 at 4 12 34 PM

After Fix

Screenshot 2022-10-24 at 4 13 02 PM

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #32693 (5f84993) into develop (48808ae) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32693      +/-   ##
===========================================
- Coverage    63.79%   63.79%   -0.01%     
===========================================
  Files          817      817              
  Lines        58453    58453              
===========================================
- Hits         37290    37289       -1     
- Misses       21163    21164       +1     
Impacted Files Coverage Δ
erpnext/controllers/queries.py 62.84% <75.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.83% <0.00%> (-0.09%) ⬇️

@rohitwaghchaure rohitwaghchaure merged commit 183662c into frappe:develop Oct 24, 2022
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Oct 24, 2022
rohitwaghchaure added a commit that referenced this pull request Oct 24, 2022
…-32693

fix: Search field not working for customer, supplier (backport #32693)
deepeshgarg007 pushed a commit that referenced this pull request Mar 28, 2023
* fix: searchfield not working for cuctsomer, supplier as per customize form

(cherry picked from commit 46d148d)

* test: added test case to validate seachfields for customer, supplier

(cherry picked from commit 5f84993)

* fix: not able to select customer / supplier

---------

Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Mar 28, 2023
## [13.49.9](v13.49.8...v13.49.9) (2023-03-28)

### Bug Fixes

* `Blanket Order` (backport [#34279](#34279)) ([#34548](#34548)) ([8ddbac5](8ddbac5))
* **client:** Amount calculation for 0 qty debit notes ([#34455](#34455)) ([19dda80](19dda80))
* exchange gain/loss GL's should be removed if advance is cancelled ([#34529](#34529)) ([00518eb](00518eb))
* german translations ([#34312](#34312)) ([661030a](661030a))
* incorrect `Opening Value` in `Stock Balance` report (backport [#34461](#34461)) ([#34622](#34622)) ([e53a96a](e53a96a))
* incorrect depr schedules after asset repair [v13] ([#34520](#34520)) ([ae88ba5](ae88ba5))
* Overallocation of 'qty' from Cr Notes to Parent Invoice ([d2a1acc](d2a1acc))
* Party Name in SOA print when viewed from Customer/Supplier master ([#34597](#34597)) ([4bdea43](4bdea43))
* Percentage billing in Sales Order ([#34606](#34606)) ([3aab6e6](3aab6e6))
* recalculate WDV rate after asset repair [v13] ([#34567](#34567)) ([c8bde39](c8bde39))
* Search field not working for customer, supplier ([#32693](#32693)) ([dbe289e](dbe289e))
* unset address and contact on trash (backport [#34495](#34495)) ([#34561](#34561)) ([7f83d15](7f83d15))
* valuation rate issue while making stock entry from PO ([3574d49](3574d49))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants