fix: Disable tax included prices for internal transfers #32794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested review from
nextchamp-saqib and
rohitwaghchaure
as code owners
github-actions
bot
added
accounts
needs-tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32794 +/- ##
========================================
Coverage 63.83% 63.84%
========================================
Files 817 817
Lines 58533 58543 +10
========================================
+ Hits 37365 37375 +10
Misses 21168 21168
|
…included_internal_transfers
deepeshgarg007
force-pushed
the
tax_included_internal_transfers
branch
from
1b0e712
to
3d26a23
Compare
|
@Mergifyio backport version-14-hotfix version-13-hotfix |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
* fix: Disable tax-included prices for internal transfers (cherry picked from commit 8d30ebb)
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
* fix: Disable tax-included prices for internal transfers (cherry picked from commit 8d30ebb)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 5, 2022
…-32794 fix: Disable tax included prices for internal transfers (backport #32794)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 5, 2022
…-32794 fix: Disable tax included prices for internal transfers (backport #32794)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
## [13.41.1](v13.41.0...v13.41.1) (2022-11-08) ### Bug Fixes * `Material Consumption` option in case of `Skip Transfer to WIP` in WO ([418c131](418c131)) * Create POS Opening Entry POS Profile filter. ([76e4bb4](76e4bb4)) * Disable tax included prices for internal transfers ([#32794](#32794)) ([84ee1b8](84ee1b8)) * for asset's purchase_date, if bill_date is set, use that instead of posting_date ([1d23c9a](1d23c9a)) * Reset advance paid amount on Oreder cancel and amend ([e32e0bc](e32e0bc)) * use `flt` instead of `cint` in `get_batch_no` ([601b1e3](601b1e3))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
# [14.6.0](v14.5.1...v14.6.0) (2022-11-08) ### Bug Fixes * `Material Consumption` option in case of `Skip Transfer to WIP` in WO ([8c856cd](8c856cd)) * add translate function to name of chart labels in budget_variance_report.py ([16f364d](16f364d)) * add translate function to name of chart labels in deferred_revenue_and_expense.py ([b8caa58](b8caa58)) * add translate function to period in stock_analytics.py ([b0c06d5](b0c06d5)) * add translate function to period in sales_analytics.py ([e681f06](e681f06)) * add translate function to string on budget_variance_report.js to match the variance word translated ([595aaad](595aaad)) * Auto advance allocation against partial invoices ([b7763d9](b7763d9)) * auto increment qty if item table has no items ([d8e403b](d8e403b)) * conflicts ([ab87a95](ab87a95)) * correct linters ([8f6f9a4](8f6f9a4)) * correct linters ([440e208](440e208)) * correct linters ([5acc9be](5acc9be)) * Create POS Opening Entry POS Profile filter. ([60af9c0](60af9c0)) * Disable tax included prices for internal transfers ([#32794](#32794)) ([6838e5e](6838e5e)) * for asset's purchase_date, if bill_date is set, use that instead of posting_date ([01a1c96](01a1c96)) * get `consumed_qty` based on `received_qty` in SCR ([ea9a502](ea9a502)) * Increase columns width in Warehouse wise Item Balance Age and Value ([0b09c31](0b09c31)) * linter ([af60c8f](af60c8f)) * make `BOM` required in SCR Item ([3f79a05](3f79a05)) * make `consumed_qty` editable when backflush based on Material Transfer ([2c5a8c4](2c5a8c4)) * make `consumed_qty` read-only in SCR Supplied Items ([68229f0](68229f0)) * map `BOM` while mapping the return SCR ([e629cba](e629cba)) * mysql syntax issue ([4d9bbd4](4d9bbd4)) * not able to select customer / supplier ([6989cdf](6989cdf)) * refactor code for better translatable string ([2dc24f2](2dc24f2)) * refactor code for better translatable string in stock_ageing.py ([0ead516](0ead516)) * rename test method ([97445d9](97445d9)) * Scan Barcode UX ([1944f4d](1944f4d)) * set `received_qty` before_validate SCR ([e316558](e316558)) * test cases ([0feec4c](0feec4c)) * trailing whitespace ([31bada9](31bada9)) * update advance paid in SO/PO from Payment Ledger ([a561432](a561432)) * use `flt` instead of `cint` in `get_batch_no` ([6510464](6510464)) ### Features * Item Wise TDS Calculation ([b9fb104](b9fb104)) ### Performance Improvements * use `get_cached_value` instead of `db.get_value` in controllers ([#32776](#32776)) ([34ca17a](34ca17a))
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
* fix: Disable tax-included prices for internal transfers (cherry picked from commit 8d30ebb)
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
## [13.41.1](frappe/erpnext@v13.41.0...v13.41.1) (2022-11-08) ### Bug Fixes * `Material Consumption` option in case of `Skip Transfer to WIP` in WO ([418c131](frappe@418c131)) * Create POS Opening Entry POS Profile filter. ([76e4bb4](frappe@76e4bb4)) * Disable tax included prices for internal transfers ([frappe#32794](frappe#32794)) ([84ee1b8](frappe@84ee1b8)) * for asset's purchase_date, if bill_date is set, use that instead of posting_date ([1d23c9a](frappe@1d23c9a)) * Reset advance paid amount on Oreder cancel and amend ([e32e0bc](frappe@e32e0bc)) * use `flt` instead of `cint` in `get_batch_no` ([601b1e3](frappe@601b1e3))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal transfers via the Sales and Purchase Transactions system by default force valuation rate for items.
This is not an issue while making Sales, but while receiving the item via a receipt or an invoice the rate is fetched from the corresponding outward document (Delivery Note or Sales Invoice). And including tax in that same rate causes a drop in the valuation
Hence to avoid this, disabling tax included rates for internal transfers