fix: opportunity list doesn't show assigned user #33110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `db_update` is performed `_assign` property is not updated and hence lead -> opportunity conversion makes it disappear from list view. Steps to reproduce: 1. Create lead 2. Assign anyone 3. Create opportunity from lead. 4. Form view shows assigned user, list view wont.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33110 +/- ##
===========================================
- Coverage 64.04% 64.03% -0.01%
===========================================
Files 816 816
Lines 58530 58533 +3
===========================================
Hits 37483 37483
- Misses 21047 21050 +3
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
Because `db_update` is performed `_assign` property is not updated and hence lead -> opportunity conversion makes it disappear from list view. Steps to reproduce: 1. Create lead 2. Assign anyone 3. Create opportunity from lead. 4. Form view shows assigned user, list view wont. (cherry picked from commit 63b9795)
ankush
added a commit
that referenced
this pull request
Nov 28, 2022
…33131) fix: opportunity list doesn't show assigned user (#33110) Because `db_update` is performed `_assign` property is not updated and hence lead -> opportunity conversion makes it disappear from list view. Steps to reproduce: 1. Create lead 2. Assign anyone 3. Create opportunity from lead. 4. Form view shows assigned user, list view wont. (cherry picked from commit 63b9795) Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
# [14.9.0](v14.8.0...v14.9.0) (2022-11-29) ### Bug Fixes * `production_item` filter in `Job Card Summary Report` ([c9f4f60](c9f4f60)) * `Work Order` filter typo in `Job Card Summary Report` ([b157193](b157193)) * Auto repeat date validations ([2aada1a](2aada1a)) * check for session user rather than owner ([c9c7222](c9c7222)) * company name with `,` in `Job Card Summary Report` ([9c6d020](9c6d020)) * company name with `,` in `Work Order Summary Report` ([bc649b3](bc649b3)) * create rounding gl entry for PCV during gle post processing ([fd4bcd9](fd4bcd9)) * Debit and Credit not equal while submitting PI containing asset item ([c11a31b](c11a31b)) * disbursable amount on currrent security price ([5edaf83](5edaf83)) * Dispatch address display ([ef687e2](ef687e2)) * incorrect balance qty ([f92b501](f92b501)) * job card for quantity UX ([59e2ab7](59e2ab7)) * MR Item `description` and `item_name` gets reset on `qty` change ([85d108b](85d108b)) * only show serial no batch selector only once ([8d0f715](8d0f715)) * opportunity list doesn't show assigned user (backport [#33110](#33110)) ([#33131](#33131)) ([0ba2a4d](0ba2a4d)) * **pos:** filter on customer groups ([c1ae5b0](c1ae5b0)) * **pos:** warehouse should be in company ([c03ec80](c03ec80)) * precision in asset test_scrap_asset ([0fe5e9a](0fe5e9a)) * production plan UX ([4607590](4607590)) * remove duplicate schema ([cdd13cd](cdd13cd)) * remove obsolete comment ([978924a](978924a)) * reposting error `AttributeError: 'datetime.timedelta' object has no attribute 'replace'` ([4b0c9b6](4b0c9b6)) * reset `voucher_type` and `voucher_no` if `based_on` is set to `Item and Warehouse` ([e530f0b](e530f0b)) * UX for inventory dimension ([f1dd4d0](f1dd4d0)) * **ux:** Action buttons in Bank Reconciliation ([93b8cc3](93b8cc3)) * validation msg in stock entry ([65ac84e](65ac84e)) * Valuation Rate column UX in stock ledger report ([5c065e8](5c065e8)) ### Features * add connections to Incoterm doctype ([89b9a06](89b9a06)) * add doctype Incoterm ([b711931](b711931)) * add german translations for incoterm titles ([f7988de](f7988de)) * add incoterm to purchasing transactions ([88346b1](88346b1)) * add incoterm to sales transactions ([fcfe0cb](fcfe0cb)) * create Incoterm records after install ([93e029d](93e029d)) * create incoterms and migrate shipments ([014896a](014896a)) * german tax templates ([5652af0](5652af0)) * item wise tds calculation for purchase order ([5f8f574](5f8f574)) * item wise tds calculation for purchase order. ([2bd8bd2](2bd8bd2)) * item wise tds in purchase order ([ba36435](ba36435)) * make Material Request for sub-assembly items ([5fc4dfa](5fc4dfa)) * **pos:** invoice: fitler warehouse by company ([c379baf](c379baf)) * validate repost item valuation against accounts freeze date ([04f50ea](04f50ea))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
db_updateis performed_assignproperty is not updated andhence lead -> opportunity conversion makes it disappear from list view.
Steps to reproduce:
reference: https://github.com/frappe/frappe/blob/7ebc0462fdef05a158786546397c9be177f729ca/frappe/desk/doctype/todo/todo.py#L67-L90