fix: disfuctional cost center filter on Journal Entries #33815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
requested review from
nextchamp-saqib and
deepeshgarg007
as code owners
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
* fix: missing cost_center filter for journal entries * test: cost center filter on invoices, journals and payments (cherry picked from commit b31b850)
ruthra-kumar
added a commit
that referenced
this pull request
Jan 27, 2023
…-33815 fix: disfuctional cost center filter on Journal Entries (backport #33815)
|
@Mergifyio backport version-14-hotfix |
✅ Backports have been created
|
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
# [14.15.0](v14.14.0...v14.15.0) (2023-01-31) ### Bug Fixes * Amount validation in Payment Request against Purchase Order ([#33855](#33855)) ([5605f1e](5605f1e)) * Currency symbol for tax withholding net total field ([#33850](#33850)) ([f54e862](f54e862)) * disfuctional cost center filter on Journal Entries ([#33815](#33815)) ([58c3e16](58c3e16)) * disposal_was_made_on_original_schedule_date ([4586806](4586806)) * double salutation on quotation print ([#33834](#33834)) ([0fcf364](0fcf364)) * Fetch commission rate from sales partner ([#33851](#33851)) ([868c8d6](868c8d6)) * **gp:** fetch buying amount from dn related to so ([f5bde9c](f5bde9c)) * GST Category validation broken for pos unregistered customer who dont have address. ([#33800](#33800)) ([f124dd3](f124dd3)) * Ignore linked JE on JE cancellation ([#33852](#33852)) ([a0e1ee0](a0e1ee0)) * item rate not fetching ([b98d351](b98d351)) * Lead to customer creation ([#33859](#33859)) ([44692e9](44692e9)) * manual depr entry not updating asset value [v14] ([#33788](#33788)) ([f487eae](f487eae)) * **patch:** validation error on cost center allocation migration ([#33835](#33835)) ([5d4967c](5d4967c)) * use correct filter name in `item_query` (backport [#33814](#33814)) ([#33816](#33816)) ([f7eabca](f7eabca)) ### Features * **gp:** test for inv and dn related via so ([7a793ea](7a793ea)) ### Performance Improvements * show update items dialog ([ac2ebfb](ac2ebfb))
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cost center filter didn't apply on Journal entries on Payment Reconciliation tool. Has been fixed now. Added a test case to catch regression.